Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move qemu image build to Docker image rather than the init tasks #4945

Closed
csweichel opened this issue Jul 26, 2021 · 3 comments · Fixed by #4959
Closed

Move qemu image build to Docker image rather than the init tasks #4945

csweichel opened this issue Jul 26, 2021 · 3 comments · Fixed by #4959
Assignees
@geropl
Labels
groundwork: in progress priority: high (dev loop impact) Gitpod development loop impacting issues

Comments

@csweichel
Copy link
Contributor

Right now we're building the agent-smith qemu image for every prebuild. Instead we should be building it once during the image build. This way, prebuilds will be considerably quicker.
@csweichel csweichel added the priority: high (dev loop impact) Gitpod development loop impacting issues label Jul 26, 2021
@csweichel
Copy link
Contributor Author

/schedule

@svenefftinge
Copy link
Member

Would the 22GB move into the image then as well?

@ghuntley
Copy link
Contributor

It's circa 2GB these days after

gitpod/components/ee/agent-smith/scripts/prepare-bpf-dev-environment.sh

Line 26 in f654391

qemu-img resize --preallocation=off bionic-server-cloudimg-amd64.img +20G
. Specific change: --preallocation=off

@geropl geropl self-assigned this Jul 26, 2021
@csweichel csweichel mentioned this issue Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geropl geropl

Labels
groundwork: in progress priority: high (dev loop impact) Gitpod development loop impacting issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dev] Move BPF VM creation into image build gitpod-io/gitpod
5 participants
@ghuntley @svenefftinge @csweichel @geropl @roboquat