Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Misleading log in additional-content-prefix-parser.ts #4733

Closed
corneliusludmann opened this issue Jul 7, 2021 · 4 comments · Fixed by #4866
Closed

[server] Misleading log in additional-content-prefix-parser.ts #4733

corneliusludmann opened this issue Jul 7, 2021 · 4 comments · Fixed by #4866
Assignees
Labels

Comments

@corneliusludmann
Copy link
Contributor

This error log is misleading. It is logged when the prefix is NOT found in the context URL:

log.error("Someone tried additionalcontent URL prefix.", {context});

@corneliusludmann corneliusludmann added component: server type: improvement Improves an existing feature or existing code labels Jul 7, 2021
@csweichel
Copy link
Contributor

/schedule

@corneliusludmann
Copy link
Contributor Author

@svenefftinge Is there a reason you added the log message? Thinking about removing this. If you would like to have it for some reason I would move it as debug log to the right place instead.

@svenefftinge
Copy link
Member

It is wrong. I wanted to get a log, if the context is an additional content context. But it's not really important so can also just be removed

@corneliusludmann
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants