Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the limit check before triggering a prebuild #4676

Closed
gtsiolis opened this issue Jul 1, 2021 · 1 comment
Closed

Move the limit check before triggering a prebuild #4676

gtsiolis opened this issue Jul 1, 2021 · 1 comment
Labels
component: dashboard feature: prebuilds meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 1, 2021

Problem to solve

Currently, when you try to open a private repository and you don't have permissions to use private repositories with Gitpod (see Pricing) you get a Limit Reached modal which is expected. However, when you try to trigger a prebuild using the URL prefix, Gitpod goes through the first steps required for triggering the prebuild before reaching the modal.

Modal Prebuild
Screenshot 2021-07-01 at 6 00 07 PM Screenshot 2021-07-01 at 6 00 21 PM

Proposal

Although the plan is to make prebuild context URLs admin only (see #4353) it could be worth considering moving the limit check for this before triggering a prebuild. 🤷

Feel free to close this if needed. 📕

TBD (To be discussed)

@gtsiolis gtsiolis added component: dashboard feature: prebuilds type: improvement Improves an existing feature or existing code labels Jul 1, 2021
@gtsiolis gtsiolis changed the title Move the limit check before initiating a prebuild Move the limit check before triggering a prebuild Jul 1, 2021
@stale
Copy link

stale bot commented Sep 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 29, 2021
@stale stale bot closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: prebuilds meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

1 participant