Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username does not change on the IDE #4390

Closed
bluefield-creator opened this issue Jun 3, 2021 · 4 comments
Closed

Username does not change on the IDE #4390

bluefield-creator opened this issue Jun 3, 2021 · 4 comments
Labels
aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. component: dashboard component: ide user experience

Comments

@bluefield-creator
Copy link

Bug description

Usernames dont get updated if you change them in any of the services supported (Bitbucket, Gitlab and Github).

I recently changed my name from Sylack-Lab to Carlos-Schrodinger, but the IDE's (Only Theia atm since I have not tested on VSCode) still show up as Sylack-Lab.

Steps to reproduce

Username problem:

  1. Create gitpod account with a github account.
  2. Change github account
  3. Relog into gitpod with the new account username
  4. Gitpod will call you your old username in some parts of the code such as extension installation
    "Do you want to install for old username here"? Even though you have a new username.

Expected behavior

To show the correct username based on my GitHub data.

Example repository

Any repository works.

Anything else?

running Chrome Dev branch

@gtsiolis gtsiolis added aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. component: dashboard component: ide user experience labels Jun 4, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 4, 2021

Hey @Carlos-Schrodinger, I was able to reproduce this. Thanks for reporting this! 💯

This happens because we pick up the name during sign up. We're considering of allowing users to change their name from the dashboard (see /account) but I'm not sure if it'd make sense to constantly sync the name from the provider as you can connect multiple providers using different names. Looping in @AlexTugarev in case they have any thoughts on this.

In the meantime, you can use a different name or email per project or for all projects using environment variables.

@bluefield-creator
Copy link
Author

Hey @Carlos-Schrodinger, I was able to reproduce this. Thanks for reporting this! 💯

This happens because we pick up the name during sign up. We're considering of allowing users to change their name from the dashboard (see /account) but I'm not sure if it'd make sense to constantly sync the name from the provider as you can connect multiple providers using different names. Looping in @AlexTugarev in case they have any thoughts on this.

In the meantime, you can use a different name or email per project or for all projects using environment variables.

Did not think about that! Thanks for helping :-)

@AlexTugarev
Copy link
Member

Hi!
I don't think the User.name attribute is or shall be updated on login. While that's true for the provider connection and the Identity info, we do not touch the User representation.

AFAIU, we're going to make the details on /account editable at some point. And all places needs to be reviewed, where we use User.identity[0].name by mistake.

@bluefield-creator
Copy link
Author

Hi!
I don't think the User.name attribute is or shall be updated on login. While that's true for the provider connection and the Identity info, we do not touch the User representation.

AFAIU, we're going to make the details on /account editable at some point. And all places needs to be reviewed, where we use User.identity[0].name by mistake.

Good to know, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. component: dashboard component: ide user experience
Projects
None yet
Development

No branches or pull requests

3 participants