Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Cannot delete account if team subscription slot is assigned #4229

Closed
AlexTugarev opened this issue May 18, 2021 · 4 comments · Fixed by #4501
Closed

[Admin] Cannot delete account if team subscription slot is assigned #4229

AlexTugarev opened this issue May 18, 2021 · 4 comments · Fixed by #4501
Assignees
Labels

Comments

@AlexTugarev
Copy link
Member

Bug description

Account deletion fails if there is a team subscription slot assigned.

Steps to reproduce

  1. Assign a team subscription slot.
  2. Try to delete the account of the assignee.
  3. See deletion fails with no feedback.

Expected behavior

Team subscription slot should be made available and deletion should succeed.

Example repository

No response

Anything else?

No response

@jankeromnes
Copy link
Contributor

FYI, I believe the bug is here: https://github.com/gitpod-com/gitpod/blob/a88ddab2ec06167186c6bce9c1fe44469a55bc50/components/server-io/src/user/user-deletion-service.ts#L24-L39 -- deletion code seems to call this.chargebeeService.cancelSubscription(...) with a paymentReference that is not a valid chargebee subscription ID.

The code doesn't seem to properly handle:

  • assigned team plan seat (which creates a "synthetic" subscription with paymentReference = '')
  • subscription purchased via GitHub (has a paymentReference that starts with github:)

@JanKoehnlein JanKoehnlein added this to the [backlog] June 2021 milestone May 31, 2021
@JanKoehnlein JanKoehnlein self-assigned this Jun 1, 2021
@JanKoehnlein
Copy link
Contributor

There is not much we can do for subscriptions via GitHub, as their API doesn't allow that. But we should notify the user.

@JanKoehnlein
Copy link
Contributor

@csweichel
Copy link
Contributor

/schedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants