Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore product reference on the login page #3664

Closed
gtsiolis opened this issue Mar 30, 2021 · 4 comments · Fixed by #4409
Closed

Restore product reference on the login page #3664

gtsiolis opened this issue Mar 30, 2021 · 4 comments · Fixed by #4409

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 30, 2021

Problem

Back in #3642 (comment), we've made the title of the login page conditional but it's not surfacing the product anymore. /cc @svenefftinge

Proposal

Restore product reference on the login page.

BEFORE AFTER
image image
@JanKoehnlein
Copy link
Contributor

Not sure: Do you expect a discussion whether we want to revert this or is it already decided?

@JanKoehnlein JanKoehnlein added this to the [backlog] June 2021 milestone Jun 1, 2021
@corneliusludmann
Copy link
Contributor

@gtsiolis: Looking at the code, it seems that the “to Gitpod” prefix is rendered only when the welcome panel on the right is there. It's not rendered, when the welcome panel is absent. Do I understand this issue right that it should be the other way around?

<h1 className="text-3xl">Log in{showWelcome ? ' to Gitpod' : ''}</h1>

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 7, 2021

Do I understand this issue right that it should be the other way around?

Ja! Thanks for taking a look at this @corneliusludmann! 💯

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 7, 2021

Do you expect a discussion whether we want to revert this or is it already decided?

@JanKoehnlein I think qualifies as two-way door decision which we can easily revert if needed. 🚪🚪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants