Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] it is not possible to select and copy text in the workspace list #3567

Closed
akosyakov opened this issue Mar 24, 2021 · 7 comments
Closed
Labels
component: dashboard priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: bug Something isn't working

Comments

@akosyakov
Copy link
Member

Bug description

Please make everything selectable and copyable, that's just annoying (not accessible) UX then it is not possible.

Steps to reproduce

Open workspaces list, try to select a URL of a workspace.

Expected behavior

No response

Example repository

No response

@akosyakov akosyakov added this to the March 2021 milestone Mar 24, 2021
@akosyakov akosyakov added component: dashboard type: bug Something isn't working labels Mar 24, 2021
@jankeromnes
Copy link
Contributor

It seems that one cannot select/copy text in <a/> links in the dashboard.

Given that an entire workspace widget is a <a/> link, selecting text in it is impossible. (Changing it into a <div/> allows selecting some text, but not where there are other <a/> links.)

I'm not sure if this is a Tailwind thing or not.

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 24, 2021

We moved with making the whole row an active link to a) make it easier to open a workspace, b) improve the information hierarchy besides structure in the workspace entry layout, as well as c) reuse the same interaction across the product (see examples modal, running workspaces modal, etc).

Eventually we will turn more text elements (repository, context, etc) into active links like the Pending Changes element. In the meantime, as a workaround you can drag and select from outside the workspace entry to select any text in there. /cc @akosyakov @jankeromnes

Removing the milestone for now. Re-added in milestone and also added stretch goal label. See relevant discussion (internal).

Screenshot 2021-03-24 at 1 21 05 PM

@gtsiolis gtsiolis removed this from the March 2021 milestone Mar 24, 2021
@gtsiolis gtsiolis added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Mar 24, 2021
@gtsiolis gtsiolis added this to the March 2021 milestone Mar 24, 2021
@svenefftinge
Copy link
Member

solved

@akosyakov
Copy link
Member Author

akosyakov commented Apr 1, 2021

I still cannot select, instead it drags the whole entry.

@akosyakov akosyakov reopened this Apr 1, 2021
@akosyakov
Copy link
Member Author

It also happens here, I cannot select any part of text or use double click to do it:
Screenshot 2021-04-01 at 15 12 59

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 1, 2021

Thanks, @akosyakov! I've added a follow up issue (see #3711) for improving this list.

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 1, 2021

Closing this, added follow up in #3712 for improving the workspaces list. /cc @akosyakov

@gtsiolis gtsiolis closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants