Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit support #2496

Open
felipecrs opened this issue Dec 10, 2020 · 8 comments
Open

Gerrit support #2496

felipecrs opened this issue Dec 10, 2020 · 8 comments
Labels
meta: never-stale This issue can never become stale type: feature request New feature or request

Comments

@felipecrs
Copy link

felipecrs commented Dec 10, 2020

Gerrit is an open-source code review tool built by Google still being used by many companies.

Also, there are some big projects out there that use Gerrit, e.g. Chromium and Android.

There is even the GerritHub, which is a free instance of Gerrit for projects hosted in GitHub.

It would be amazing if Gitpod could add support Gerrit, by supporting the prebuild of Gerrit Change Requests for example.

@gtsiolis
Copy link
Contributor

Thanks for adding this @felipecrs! Adding more git providers, like #80, is something we could consider in the future based on demand, see #80 (comment).

@felipecrs felipecrs changed the title Support Gerrit Gerrit support Dec 10, 2020
@svenefftinge svenefftinge added type: feature request New feature or request and removed feature request labels Jan 7, 2021
@stale
Copy link

stale bot commented Mar 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2021
@nohe427
Copy link

nohe427 commented Mar 24, 2021

This would make developing Chromium based browsers easier as gerrit is the source for Chromium

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 24, 2021
@felipecrs
Copy link
Author

And a lot of third parties which uses Gerrit privately.

@JanKoehnlein
Copy link
Contributor

@nohe427
Copy link

nohe427 commented Mar 25, 2021

Did anybody try https://marketplace.visualstudio.com/items?itemName=tht13.gerrit-vscode

I think the goal is to be able to launch gitpod from gerrit, not necessarily a gerrit vscode integration

@felipecrs
Copy link
Author

felipecrs commented Mar 25, 2021

@JanKoehnlein you instigated me to try. And was not working, but now it is:

tht13/gerrit-vscode#13

=)

@felipecrs
Copy link
Author

It's available under https://marketplace.visualstudio.com/items?itemName=felipecrs.vscode-gerrit in case anyone wants to test.

@ghuntley ghuntley added the meta: never-stale This issue can never become stale label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants