Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other users can't load my prebuild #18752

Open
shaal opened this issue Sep 19, 2023 · 11 comments
Open

Other users can't load my prebuild #18752

shaal opened this issue Sep 19, 2023 · 11 comments
Labels
meta: never-stale This issue can never become stale type: bug Something isn't working

Comments

@shaal
Copy link
Contributor

shaal commented Sep 19, 2023

Bug description

DrupalPod repo is based on the fact that I run the prebuild ahead of time, and all other users open the workspace and ready to work.
A user reported that when they open a workspace with DrupalPod, instead of loading the prebuild, when opening the workspace init task starts running.

Steps to reproduce

Open https://github.com/shaal/gitpod--prebuild-for-other-users in Gitpod by following this link -
https://gitpod.io/#https://github.com/shaal/gitpod--prebuild-for-other-users

There's a 60 seconds countdown timer that already ran in prebuild, if you see the countdown in your workspace, it failed loading prebuild.

Workspace affected

No response

Expected behavior

When a prebuild is available, any user who open the workspace should get the prebuild.

Example repository

https://github.com/shaal/gitpod--prebuild-for-other-users
https://github.com/shaal/DrupalPod

Anything else?

It seems to be inconsistent who gets to load prebuild and who doesn't.
@rfay can load prebuilds of my repos, @tyler36 cannot load prebuild of my repos.

Tyler36 couldn't load the prebuild for https://github.com/shaal/ddev-gitpod, after I confirmed the prebuild loads for me.
I asked him to fork my ddev-gitpod repo, and generate the prebuild in his Gitpod account - https://github.com/tyler36/ddev-gitpod
He was able to open his fork and it loaded the prebuild for him.
I tried opening his fork but it did NOT load the perbuild for me.

@shaal shaal added the type: bug Something isn't working label Sep 19, 2023
@rfay
Copy link

rfay commented Sep 19, 2023

Was it ever intentional with Gitpod that one user would be able to use the prebuilds of another user?

@rfay
Copy link

rfay commented Sep 19, 2023

@shaal a better title might be "Other users can't load my prebuild" or something like that?

@shaal shaal changed the title Prebuilds not loading for all users Other users can't load my prebuild Sep 19, 2023
@shaal
Copy link
Contributor Author

shaal commented Sep 19, 2023

@rfay I found this in the docs -

Prebuilds are shared!

Gitpod can trigger a prebuild whenever there is a commit to a repository. That prebuild will then be used for all new workspaces opened on that branch. This is ideal for working together on branches for testing or code reviews.
https://www.gitpod.io/docs/configure/projects/prebuilds#prebuilds-are-shared

@axonasif
Copy link
Member

Hi @shaal, sorry for the trouble.

Can you please check if you have prebuilds enabled on the project settings for the repos you mentioned?
Screenshot 2023-09-22 at 7 47 23 PM

@shaal
Copy link
Contributor Author

shaal commented Sep 22, 2023

@axonasif yes, prebuilds are enabled on these projects/repos. I use these prebuilds myself, and I've been using prebuilds successfully for a couple of years now.
The new issue is that some people do not get the prebuild loaded in their workspace, while other people do.

@shaal
Copy link
Contributor Author

shaal commented Sep 26, 2023

(removed this comment)

@tyler36
Copy link

tyler36 commented Oct 26, 2023

Still having the issue with not get prebuilds from @shaal 's repo.

@axonasif
Copy link
Member

axonasif commented Dec 12, 2023

Sorry for the late update on this. There has been a few other people asking about it. I learned that only organization members tied to the Gitpod project can load the prebuild.

See https://www.gitpod.io/docs/configure/projects/prebuilds#prebuilds-are-only-available-to-organization-members

We may need to introduce an option to allow public loading of prebuilds.

@shaal
Copy link
Contributor Author

shaal commented Feb 9, 2024

@axonasif The approach you described in your last comment would be a breaking change, since previously everyone was able to use the existing prebuilds for a repository.

This is also related to my separate feature request at #19175 - if Gitpod saved a prebuild whenever someone opened a commit or branch in a workspace (after running all .gitpod.yml tasks), it could save a lot of resources. By default caching that state as a prebuild, Gitpod could avoid re-running all the setup each time, which would be more efficient.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the meta: stale This issue/PR is stale and will be closed soon label May 23, 2024
@tyler36
Copy link

tyler36 commented May 24, 2024

Still on issue.

@Siddhant-K-code Siddhant-K-code added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants