Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review perf impact of gp rebuild on workspace caching, backup performance, etc. #16480

Closed
Tracked by #7671
loujaybee opened this issue Feb 20, 2023 · 6 comments
Closed
Tracked by #7671
Labels
meta: stale This issue/PR is stale and will be closed soon

Comments

@loujaybee
Copy link
Member

loujaybee commented Feb 20, 2023

Currently gp rebuild encourages users to update their images. However, we need to review the potential impact this has on workspace image caching, particularly as the images users use become more unique, the cache hits should decrease. We need to understand the impact this has on workspace performance. This issue is to gather data on the impact, so that we can make any decisions (or not) on how to modify, or improve either workspace caching, or the gp rebuild feature.

@loujaybee
Copy link
Member Author

@gitpod-io/engineering-workspace -> Any tips and pointers to this data, or support in gathering and analysing the data would be useful.

@loujaybee
Copy link
Member Author

loujaybee commented Feb 21, 2023

Adding to @gitpod-io/engineering-workspace inbox for visibility, and input, but the IDE team will continue to own and drive the investigation and data analysis work for now.

@loujaybee loujaybee changed the title Review performance impact of gp rebuild Review performance impact of gp rebuild on workspace caching, and backup performance Feb 21, 2023
@loujaybee loujaybee changed the title Review performance impact of gp rebuild on workspace caching, and backup performance Review perf impact of gp rebuild on workspace caching, backup performance, etc. Feb 21, 2023
@kylos101
Copy link
Contributor

kylos101 commented Feb 21, 2023

encourages users to update their images

How is gp rebuild doing? Can you share an example?

However, we need to review the potential impact this has on workspace image caching, particularly as the images users use become more unique, the cache hits should decrease.

I assume you are referring to workspace node and IPFS cache misses, and not a cache miss in-workspace using Docker in Workspace?

We need to understand the impact this has on workspace performance.

Less cache hits will increase start times. We have several SLOs here, for example.

the IDE team will continue to own and drive the investigation and data analysis work for now.

Given ☝️ adding to IDE team inbox.

edit: @laushinka for 👀

@loujaybee
Copy link
Member Author

loujaybee commented Feb 23, 2023

Thanks, @kylos101 ! 🙏

How is gp rebuild doing? Can you share an example?

We're are not doing this (nudging users to update workspace images) yet. However, a natural consequence of the feature might be more custom images, as it makes the configuration loop simpler. In future we (after a clean up of workspace images) we might get more pushy nudging users to different workspace images.

I assume you are referring to workspace node and IPFS cache misses, and not a cache miss in-workspace using Docker in Workspace?

Yep, general workspace cache is the question, not in workspace cache. However in workspace cache I presume will affect backup sizes, which is another dimension/topic of the issue 🙏

@loujaybee
Copy link
Member Author

Dropping, will pick up in future.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

No branches or pull requests

2 participants