Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BillingMode] Filter out FREE and FREE_50 plans explicitly #16231

Closed
geropl opened this issue Feb 6, 2023 · 0 comments · Fixed by #16270
Closed

[BillingMode] Filter out FREE and FREE_50 plans explicitly #16231

geropl opened this issue Feb 6, 2023 · 0 comments · Fixed by #16270
Assignees
@geropl
Labels
component: server feature: billing ⚙️ Groundwork team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@geropl
Copy link
Member

geropl commented Feb 6, 2023

When calculating BIllingMode, we currently treat the FREE and FREE_50 plans as "paid" when they are persisted on the database (something we did until some time 2019). 🐛

We should filter them out here.
@geropl geropl added type: bug Something isn't working component: server labels Feb 6, 2023
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Feb 6, 2023
@geropl geropl self-assigned this Feb 7, 2023
@gtsiolis gtsiolis added team: webapp Issue belongs to the WebApp team feature: billing labels Feb 7, 2023
@geropl geropl changed the title {BillingMode] Filter out FREE and FREE_50 plans explicitly [BillingMode] Filter out FREE and FREE_50 plans explicitly Feb 7, 2023
@geropl geropl mentioned this issue Feb 7, 2023
Merged
9 tasks
@geropl geropl moved this from Scheduled to In Validation in 🍎 WebApp Team Feb 7, 2023
@geropl geropl moved this from In Validation to Done in 🍎 WebApp Team Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geropl geropl

Labels
component: server feature: billing ⚙️ Groundwork team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
🍎 WebApp Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[server] Ignore old FREE/FREE_50 when evaluating BillingMode gitpod-io/gitpod
2 participants
@gtsiolis @geropl