-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove slugs for orgs #16053
Comments
This sounds more future-proof and flexible enough to break free from the structures that may exist in GitHub organizations, GitLab groups or sub-groups, etc. ✔️ @svenefftinge Does it make sense for projects and everything under a project (prebuilds, settings) to keep their URL? ☝️ In this or any case, is this a good opportunity to consider introducing a new path structure with prefixing everything with
Possible use cases:
|
I'm tempted to use the project id instead of a name/slug. That way we could tell users to switch to another org (and optionally don't ask again) if they are clicking a link to that project. Using the name there might be confusion if the same name is used in different orgs. wdyt? |
2 cents: What if we mix both? :D Similar to how Notion does it for example. {GITPOD_URL}/.../:id works but redirects to {GITPOD_URL}/.../:name-:id. It guarantees that the link points to the exact project, while providing visual aid to the user |
Sounds good! I would love to do that later once we feel like the URL needs to contain the project name as well? Seems like we could easily add such a redirect later. unlike notion, I believe the context in gitpod (i.e. project name) is very visible. |
@svenefftinge DEAL 🤝—We've also run into duplicate naming issues in the past, see #6600 and #6883. Unless it does not make sense or sound sane to do, maybe we could we also trim the IDs used for the URL to have shorter URLs when someone is visiting a project or a prebuild, for example:
+1
Indeed, this will be more visible with changes in #16046, see screenshots below. Cc @atduarte
|
@svenefftinge I'm ok with that. Notion adds the page title to the URL even though it's very visible when you open it. It helps when you have a list of links and want to know what is it about or for example you are sharing a link in Slack and want to make sure you are linking to the correct thing. |
I would not require the prebuilds to be a sub-resource of the project URLs if we use UUIDs. |
Sounds good—LET'S DO THIS. 🏀 |
We are moving away from orgs/teams being a secondary folder in which you maintain projects, towards orgs that act as a globally active context in which a user interacts with Gitpod. (see #15980 )
To that end it doesn't make sense to keep the slugs per org, instead we can allows a searchParam (in any dashboard URL) that will set the currently active org. The currently active org should be set in the browser session as well as in the settings, so that all existing APIs can obtain the active org if it is not passed explicitly (we can eventually move to explicitly passing the org as an argument).
Operations such as create workspace would use whatever context is set.
Starting existing workspaces should not use the global setting but restart the workspace in the org the workspace belongs to.
The text was updated successfully, but these errors were encountered: