Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to close or dismiss the new workspace with options modal when opening the modal from the projects page #15696

Closed
gtsiolis opened this issue Jan 11, 2023 · 1 comment · Fixed by #15914
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 11, 2023

Problem to solve

Following up from #15668 and the feedback in #15668 (comment), 🅰️ the current UX when a user is clicking on the New Workspace ... menu option from the project card is redirecting the user to the workspace start page to show the start with options modal.

In contrast, 🅱️ when clicking CMD+O on the projects list the new workspace with options modal is overlapping the content and you can dismiss or close the modal by clicking the X button on the modal or pressing ESC.

Usually, for a modal component, there should always be multiple ways to close or dismiss this type of modal.

Although 🅱️ does not carry any context (repository) information, which could be considered later, it can be dismissed.

Cc @svenefftinge @jldec @geropl

Modal with options from the project more actions menu Modal with options from the CMD+O shortcut
Screenshot 2023-01-11 at 6 21 38 PM (2) Screenshot 2023-01-11 at 6 21 46 PM (2)

Proposal

Following the suggestion from #15668 (comment):

The options modal should go away and return you to the dashboard when you hit escape. It should also have a close button.

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Jan 11, 2023
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Jan 13, 2023
@jldec jldec added type: bug Something isn't working and removed type: improvement Improves an existing feature or existing code labels Jan 13, 2023
@jldec
Copy link
Contributor

jldec commented Jan 13, 2023

Being unable to dismiss the modal is a bug in the implementation and unfortunately, quite jarring / surprising.

Scheduling and hoping for a quick followup fix please. 🙏
cc: @svenefftinge @selfcontained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: In Validation
Development

Successfully merging a pull request may close this issue.

2 participants