Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetBrains] Consider reducing the Gateway integration tests to a single IDE #15563

Closed
felladrin opened this issue Jan 4, 2023 · 3 comments
Closed
Labels
aspect: tech-debt Issues related to engineering tech debt aspect: testing Anything related to testing Gitpod manually, automated integration tests or even unit tests editor: jetbrains meta: stale This issue/PR is stale and will be closed soon team: IDE

Comments

@felladrin
Copy link
Contributor

felladrin commented Jan 4, 2023

Description

JetBrains Integration Tests usually fail as they take more than 1h to complete (here, for example, search for "test timed out after 1h0m0s"). When it happens, we're required to run the tests manually [1].

As we're testing only the Gateway connection with the backend IDE at this moment, we could reduce it to 1 backend IDE (IDEA or Rider), as their codebase (IntelliJ) works the same for all. This would reduce in 87% the time to run Werft Build during PRs.

Related Issues

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Jan 4, 2023

I have been investigating how to improve integration tests for JetBrains in the past days, and one thing I've noticed is that we wait 3 minutes at least, just for the workspace to start, which means 8 IDEs * 3 min = 24 minutes of wait, plus prev env build time etc.. it quickly reaches 1h.

It would be interesting if we could parallelise the tests, however 1 prev env won't be enough (unless we create a bigger VM), or we use 1 prev env for each IDE, but it feels like a waste.

Alternatively, we could test random IDEs each day, e.g. (2 out of 8)

@felladrin
Copy link
Contributor Author

Agreed.
I like this idea of rotating the IDEs for tests!

@andreafalzetti andreafalzetti moved this to Scheduled in 🚀 IDE Team Jan 9, 2023
@loujaybee loujaybee added editor: jetbrains aspect: tech-debt Issues related to engineering tech debt aspect: testing Anything related to testing Gitpod manually, automated integration tests or even unit tests team: IDE labels Jan 9, 2023
@andreafalzetti andreafalzetti removed the status in 🚀 IDE Team Jan 9, 2023
@loujaybee loujaybee moved this to Scheduled in 🚀 IDE Team Jan 9, 2023
@andreafalzetti andreafalzetti self-assigned this Jan 16, 2023
@felladrin felladrin moved this from Scheduled to In Progress in 🚀 IDE Team Jan 20, 2023
@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 9, 2023
@stale stale bot closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: tech-debt Issues related to engineering tech debt aspect: testing Anything related to testing Gitpod manually, automated integration tests or even unit tests editor: jetbrains meta: stale This issue/PR is stale and will be closed soon team: IDE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants