Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBP] Don’t immediately block free-tier users with heavy prebuild usage when UBP is enabled #14814

Closed
3 tasks done
Tracked by #14969
jldec opened this issue Nov 21, 2022 · 4 comments
Closed
3 tasks done
Tracked by #14969
Assignees
Labels
❓ clarification required team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Nov 21, 2022

Users with a lot of prebuild usage should not be blocked immediately when we turn on UBP.

Taking the following steps to address this:

Earlier suggestions

  • Enabling UBP should reset the free tier cost center to 500 fresh credits even if past usage was higher
  • Users with high prebuild usage should see a warning notification when they have used 400/500 credits

Related to #9898

See RFC (internal) for more details

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Nov 21, 2022
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Nov 21, 2022
@jldec
Copy link
Contributor Author

jldec commented Nov 23, 2022

Clarification required - Let look at usage data to see how many cases like this are expected.

@jldec jldec self-assigned this Nov 23, 2022
@svenefftinge
Copy link
Member

Users with high prebuild usage should see a warning notification when they have used 400/500 credits

I'd prefer to generalize this warning to all kinds of low credits. We could email people on low credits.

@jankeromnes
Copy link
Contributor

jankeromnes commented Nov 24, 2022

Users with a lot of prebuild usage should not be blocked immediately when we turn on UBP.

To clarify, why shouldn't they get blocked immediately? (I.e. why is that problematic?)

My thinking is:

  • Some users may have an extraordinarily heavy prebuild usage, but this isn't intentional
  • When we switch to usage-based GA, they notice this heavy usage (i.e. they get blocked, see a notification, check out their usage, see what is causing the excessive usage)
  • Armed with this knowledge, these users can then fix their excessive prebuilds (e.g. by deleting their unused projects, or restricting prebuilds to only the main branch, something like that)
  • Problem solved ✅ ?
  • Users with high prebuild usage should see a warning notification when they have used 400/500 credits

We already have this, right?

} else if (limit.almostReached) {
result.unshift(`You have reached 80% or more of your usage limit.`);
}

We could email people on low credits.

This sounds like an excellent additional feature request. 👍

@jldec
Copy link
Contributor Author

jldec commented Dec 6, 2022

Clarified OP - thanks @jankeromnes, I think your fixes are going to do a lot to help here.

@jldec jldec closed this as completed Dec 6, 2022
Repository owner moved this from Scheduled to In Validation in 🍎 WebApp Team Dec 6, 2022
@jldec jldec moved this from In Validation to Done in 🍎 WebApp Team Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓ clarification required team: webapp Issue belongs to the WebApp team
Projects
Status: Done
Development

No branches or pull requests

3 participants