Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projects] Introduce "no setting", i.e. default to user's setting for workspace classes #14810

Closed
svenefftinge opened this issue Nov 21, 2022 · 6 comments
Assignees
Labels
type: bug Something isn't working

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Nov 21, 2022

The workspace classes on the projects setting don't make a visual distinction between "no setting" and the set to the default class. But internally the difference is that an explicit project-level setting overrules any user settings.

We need a way in the project settings that communicates/allows setting to "default/ no setting".

@jldec jldec moved this to Scheduled in 🍎 WebApp Team Nov 21, 2022
@jldec jldec added the type: bug Something isn't working label Nov 21, 2022
@jldec
Copy link
Contributor

jldec commented Nov 21, 2022

Bumping priority on this because the feature is very difficult to use right now.

The setting shows one of options highlighted on the default value (e.g. based on your user preference) , as if selected, even though no preference has been stored in the project..

After clicking on the already-highlighted choice, it becomes selected and persisted, but there is no visual feedback at all.

cc: @svenefftinge @gtsiolis

@jldec
Copy link
Contributor

jldec commented Nov 21, 2022

@svenefftinge @gtsiolis

How about showing the "use default" (no setting) state in both personal and project settings?
This would allow for users to receive a different default when it is modified say at the org level 😉 .

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 23, 2022

@jldec From UX perspective, a straightforward solution could be to automatically select and actually set a default (standard) class when someone adds a project. Does this sound like a good MVC forward?

question: Do we want to ask users to go through all projects they add and set a workspace class?

💭 thought: Since we’re introducing the same setting on a user, project, and maybe later team and org level, maybe this is more about communicating clearly if a setting is inherited.

Some thoughts on the card component:

  1. The selectable card component was designed to never have an unselected state. We could add an unselected state, but this would slightly decrease the effectiveness of this component.
  2. The workspace class selection, just like the editor selection, will undergo a redesign so that it's more flexible and scalable, see Replace the editor selection cards with the new dropdown component used in the start with options new workspace modal #13116. In that case, having an unselected state sounds better and more viable.

@jldec
Copy link
Contributor

jldec commented Nov 23, 2022

@gtsiolis
This configuration on projects is optional and the selection UI needs an unselected state.

New and existing projects have no workspace class config and the UI should show that, because it means that the user's preference, or the installation default will be used. Simply showing that default as selected is confusing/wrong because it depends on who is looking at the setting and what their personal preference is at the time.

Going into project settings in order to change the setting is how project owners override the user or installation default.
In gitpod.io, they should see 3 choices and on first use, 1 will be highlighted.

  1. Use default e.g. if configured in personal preferences
  2. Standard
  3. Large

@svenefftinge
Copy link
Member Author

svenefftinge commented Dec 2, 2022

we don't need this for now, as we have removed the user settings for workspace classes. Maybe introduce it once we have policies for workspace classes on team and org level.

Repository owner moved this from Scheduled to In Validation in 🍎 WebApp Team Dec 2, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 2, 2022

Thanks @svenefftinge @jldec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants