Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVC] investigate we could avoid the cannot mount workspace error #14032

Closed
jenting opened this issue Oct 20, 2022 · 6 comments · Fixed by #14383
Closed

[PVC] investigate we could avoid the cannot mount workspace error #14032

jenting opened this issue Oct 20, 2022 · 6 comments · Fixed by #14383
Assignees
Labels
component: ws-manager team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@jenting
Copy link
Contributor

jenting commented Oct 20, 2022

Bug description

The user hits the cannot mount workspace error. Not sure if it's an intermediate state or not.
If it's an intermediate state, we could ignore it just like we ignore the error here.
If not, see if we could recreate the PVC and remount rather than report the error to the user.

It causes the cannot mount workspace error comes first and then makes the issue happens.

https://gitpod.slack.com/archives/C0201TXMV54/p1666253166702419

Steps to reproduce

We don't know.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

#7901

@jenting jenting added the type: bug Something isn't working label Oct 20, 2022
@jenting jenting added component: ws-manager team: workspace Issue belongs to the Workspace team labels Oct 20, 2022
@kylos101
Copy link
Contributor

kylos101 commented Oct 20, 2022

@sagor999 this error happened in us72 and eu71.

Logs, edit: this error was logged for 3 workspace instances only.

However, what's really weird about this is, one of the instances that landed in us72 also landed (with the same ID) in us71.

Logs for one instance

Looping in @geropl , because I believe this is not supposed to happen.

@sagor999
Copy link
Contributor

However, what's really weird about this is, one of the instances that landed in us72 also landed (with the same ID) in us71.

maybe because each StartWorkspace request selects cluster prior to making the call? And due to traffic shift in the process, it landed on a different cluster.

@kylos101
Copy link
Contributor

kylos101 commented Oct 20, 2022

@geropl I'll create a separate issue to socialize the below:

I would have expected startWorkspace requests to different clusters to have used different instance IDs. I could also be wrong.

I recall that ws-manager-api retrys, it seems like it is initialized to zero retry attempts, though in the logs it looks like it is retrying.

For example, the first one was to us71, and 7 seconds later the second one was to us72. 🤔

There are some logged warnings for server where it cannot connect and retries.

@svenefftinge
Copy link
Member

FWIW I just had the "cannot mount workspace" error when starting gitpodio-gitpod-zjkqtz6c188.
Giving it another try worked.

@jenting
Copy link
Contributor Author

jenting commented Nov 3, 2022

Two options:

@jenting jenting self-assigned this Nov 3, 2022
@sagor999
Copy link
Contributor

sagor999 commented Nov 3, 2022

@jenting lets try with first option first (We could consider treating the"cannot mount workspace" error as an intermediate state in ws-manager) and if that not going to fix it, then we can go with option two of recreating the pod.
Since it is hard to repro and verify this issue, we would have to deploy option 1 first and see if that would resolve this problem.

@jenting jenting moved this to In Progress in 🌌 Workspace Team Nov 3, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Nov 3, 2022
@Furisto Furisto moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Nov 21, 2022
@jenting jenting moved this from In Validation to Done in 🌌 Workspace Team Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ws-manager team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants