Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Automatic detection of whether PVC is operational or not #13559

Closed
utam0k opened this issue Oct 4, 2022 · 12 comments
Closed

test: Automatic detection of whether PVC is operational or not #13559

utam0k opened this issue Oct 4, 2022 · 12 comments
Labels
team: workspace Issue belongs to the Workspace team

Comments

@utam0k
Copy link
Contributor

utam0k commented Oct 4, 2022

Is your feature request related to a problem? Please describe

The self-hosted test is not an environment in which PVC can operate. Currently, we have to change the code to make the test work.
We can reduce this friction by detecting if the PVC test can run and skipping the test if necessary.

Describe the behaviour you'd like

Pass the test on an env without PVC env

Describe alternatives you've considered

Additional context

@utam0k utam0k added the team: workspace Issue belongs to the Workspace team label Oct 4, 2022
@kylos101
Copy link
Contributor

kylos101 commented Oct 4, 2022

@utam0k how would you recommend we do? For example, one option might be to change the configmap which stores the installer settings used to install Gitpod. If PVC is enabled there, then proceed with testing PVC. Can you think of any other ideas?

cc: @sagor999 @jenting

@utam0k
Copy link
Contributor Author

utam0k commented Oct 4, 2022

That's one way to go. Sorry but I don't have any specific ideas at the moment. I'd like to here @sagor999 and @jenting options.

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022

Not sure if it's doable or not.

We could check the CSI driver contains the CREATE_DELETE_SNAPSHOT capability to determine whether we should test PVC or not.

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

@utam0k
Copy link
Contributor Author

utam0k commented Oct 5, 2022

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

@kylos101 @jenting
I would recommend relying on our product rather than relying on Kubernetes because I think it is easier to control and understand mechanism.

@kylos101
Copy link
Contributor

kylos101 commented Oct 5, 2022

Rely on product how @utam0k ? Do you mean like a Gitpod config map, which contains installer options used to do the last install or upgrade?

@utam0k
Copy link
Contributor Author

utam0k commented Oct 5, 2022

We could check the CSI driver contains the CREATE_DELETE_SNAPSHOT capability to determine whether we should test PVC or not.

Oh no, I was trying to figure out which of the two methods JenTing suggested would be easier for us to do. Presumably, the capability of the above method is a value that is managed by Kubernetes, right? Well, I think both methods are very good.

@utam0k
Copy link
Contributor Author

utam0k commented Oct 5, 2022

So, I recommend this one

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022

@utam0k
Could you please help to check the ws-manager ConfigMap snapshotClass is empty in the self-hosted installation?

@utam0k
Copy link
Contributor Author

utam0k commented Oct 6, 2022

@jenting It looks like snapshotClass is always ""

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022

@jenting It looks like snapshotClass is always ""

Thank you 🙏

@jenting
Copy link
Contributor

jenting commented Nov 24, 2022

The PVC integration test is disabled #14838. This issue is no longer valid.

@jenting jenting closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2022
@jenting jenting moved this to Awaiting Deployment in 🌌 Workspace Team Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

No branches or pull requests

3 participants