-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Automatic detection of whether PVC is operational or not #13559
Comments
Not sure if it's doable or not. We could check the CSI driver contains the CREATE_DELETE_SNAPSHOT capability to determine whether we should test PVC or not. |
Or, we could check the ws-manager ConfigMap, |
Rely on product how @utam0k ? Do you mean like a Gitpod config map, which contains installer options used to do the last install or upgrade? |
Oh no, I was trying to figure out which of the two methods JenTing suggested would be easier for us to do. Presumably, the capability of the above method is a value that is managed by Kubernetes, right? Well, I think both methods are very good. |
So, I recommend this one
|
@utam0k |
@jenting It looks like |
Thank you 🙏 |
The PVC integration test is disabled #14838. This issue is no longer valid. |
Is your feature request related to a problem? Please describe
The self-hosted test is not an environment in which PVC can operate. Currently, we have to change the code to make the test work.
We can reduce this friction by detecting if the PVC test can run and skipping the test if necessary.
Describe the behaviour you'd like
Pass the test on an env without PVC env
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: