Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the bash script from installer-job to Installer container image #12197

Closed
Tracked by #12196
mrsimonemms opened this issue Aug 18, 2022 · 0 comments · Fixed by #12202
Closed
Tracked by #12196

move the bash script from installer-job to Installer container image #12197

mrsimonemms opened this issue Aug 18, 2022 · 0 comments · Fixed by #12202
Assignees

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Aug 18, 2022

The bash script in the KOTS installer job has become far bigger than was ever intended. Having this written in the args section of a Kubernetes job is now working against us and we lose code completion, shellcheck by having it in there.

Move the script in the job into /scripts directory in the Installer and copy these into the container image at build stage so these can be run.

The {{repl }} options that are rewritten by KOTS at runtime will need to be passed to the script as environment variables, ensuring that no sensitive values are passed in this way. All efforts should be taken to remove the need for these in the scripts entirely and use secrets for these if they cannot be avoided entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant