Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Get rid of OTS] Add an integration test for protected_secrets feature flag #11318

Closed
Tracked by #10134
jenting opened this issue Jul 12, 2022 · 3 comments · Fixed by #13493
Closed
Tracked by #10134

[Get rid of OTS] Add an integration test for protected_secrets feature flag #11318

jenting opened this issue Jul 12, 2022 · 3 comments · Fixed by #13493
Assignees
@Furisto
Labels
priority: high team: workspace Issue belongs to the Workspace team

Comments

@jenting
Copy link
Contributor

jenting commented Jul 12, 2022 •
edited by kylos101
Loading

Is your feature request related to a problem? Please describe

Add integration for the protected_secrets feature flag.

Describe the behaviour you'd like

Have an integration test for the protect_secrets feature flag, it'd be good to test both public and private repo is able to launch a workspace and stops the workspace where the context is a private Git repo (not a prebuild).

Describe alternatives you've considered

Additional context

#11198
@jenting jenting added the team: workspace Issue belongs to the Workspace team label Jul 12, 2022
@kylos101 kylos101 moved this to Scheduled in 🌌 Workspace Team Jul 12, 2022
@kylos101
Copy link
Contributor

Thank you for creating this, @jenting ! 🙏

@atduarte atduarte mentioned this issue Jul 14, 2022
Closed
12 tasks
@atduarte atduarte removed the status in 🌌 Workspace Team Jul 14, 2022
@jenting jenting self-assigned this Jul 21, 2022
@jenting jenting moved this to In Progress in 🌌 Workspace Team Jul 21, 2022
@jenting jenting moved this from In Progress to Scheduled in 🌌 Workspace Team Jul 21, 2022
@kylos101
Copy link
Contributor

@jenting I am going to remove you for now. If you decide to do in the future, please assign yourself back.

@jenting jenting mentioned this issue Aug 23, 2022
Closed
@kylos101
Copy link
Contributor

kylos101 commented Sep 6, 2022

Consider using the identify related to this user token

@atduarte atduarte moved this to In Progress in 🌌 Workspace Team Sep 30, 2022
@atduarte atduarte changed the title [workspace integration test] Add an integration for protected_secrets feature flag [Get rid of OTS] Add an integration for protected_secrets feature flag Sep 30, 2022
@Furisto Furisto mentioned this issue Sep 30, 2022
Merged
3 tasks
@atduarte atduarte changed the title [Get rid of OTS] Add an integration for protected_secrets feature flag [Get rid of OTS] Add an integration test for protected_secrets feature flag Sep 30, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Sep 30, 2022
@Furisto Furisto moved this from Awaiting Deployment to Done in 🌌 Workspace Team Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Furisto Furisto

Labels
priority: high team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test] Test protected secrets gitpod-io/gitpod
3 participants
@kylos101 @Furisto @jenting