Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE selection modal window not fiting in screen #10747

Closed
FabienTregan opened this issue Jun 18, 2022 · 4 comments
Closed

IDE selection modal window not fiting in screen #10747

FabienTregan opened this issue Jun 18, 2022 · 4 comments
Assignees
Labels
component: dashboard meta: never-stale This issue can never become stale type: bug Something isn't working

Comments

@FabienTregan
Copy link

Bug description

After first login, you are shown a modal windows to select you IDE.
On low resolution screen (mine is 1366x768), the window does not fit in screen, there is no scrollbar and you don't even know there is a button that must be clicked (which is outside the screen)

image

Steps to reproduce

have a low resolution screen
register account
log in

Workspace affected

No response

Expected behavior

the windows fits in screen or there is a scrollbar

Example repository

No response

Anything else?

No response

@FabienTregan FabienTregan added the type: bug Something isn't working label Jun 18, 2022
@geropl
Copy link
Member

geropl commented Jul 21, 2022

@gtsiolis pinging you for awareness. I feel it would be nice to have a general solution for all our pages - even if it's suboptimal, e.g. like adding a scrollbar.

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 21, 2022

Thanks for noticing, @FabienTregan! 👀

🅰️ Using a scrollbar area in the modal would be great and has been needed in the past, see #3829. Sounds also like a good skateboard and boring (simple) solution, towards improving the overall responsive design of the dashboard (#4050). 🛹

🅱️ FYI, In the future, I'd expect the editor selection card component to be replaced with a more flexible dropdown component, which would resolve the issue here, see screenshot below. Generally, keeping contents of the modal short and sweet sounds ideal. In this case, we also wanted to reuse the same components.

Thanks for the ping, @geropl! 🏓

Early design for editor selection through a dropdown
Editors

@stale
Copy link

stale bot commented Oct 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 20, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Oct 20, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 5, 2022

Closing this as it has been resolved in #15084. Thanks, @selfcontained!

@gtsiolis gtsiolis closed this as completed Dec 5, 2022
@gtsiolis gtsiolis moved this to In Validation in 🍎 WebApp Team Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale type: bug Something isn't working
Projects
Status: In Validation
Development

No branches or pull requests

4 participants