Have labels on GCP Disks and Snapshots

[jenting]

Is your feature request related to a problem? Please describe

We need to add labels to GCP Disks and Snapshots because we use labels to filter the cost.

Describe the behaviour you'd like

Make the GCP Disks and Snapshots have labels so we are able to filter the cost.

Describe alternatives you've considered

N/A

Additional context

#10186 (comment)

#7901

[sagor999]

Spent some time researching how to do that and have a plan now.
There is already support for adding labels to disk via adding a parameter to storage class like so:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: csi-gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
  type: pd-balanced
  replication-type: none
  labels: cluster=preview,region=us

So for disks we can implement this by using this param and creating a storage class for each workspace class. Since each workspace class can specify its own storage class, it should work just fine.

There is no such support for VolumeSnapshotClass though, but it should not be too difficult to add support for it in gce-csi driver, so going to do that next.

[sagor999]

Upstream PR: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1017

[jenting]

Upstream PR: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1017

Code merged, waits for the next release 🚀

[jenting]

It's good to add the cluster name to the label, so we can easily file the cluster by the label on the GCP console.

[sagor999]

This PR enables labels on disks.
Once upstream will release new gsi driver containing my fix for allowing to add labels to snapshot classes, we will do the same for snapshots. Until then I will add blocked label.

[kylos101]

@sagor999 is there an ETA for upstream to release new driver?

[sagor999]

Not as far as I know... :( Just have to wait, or we can build it ourselves and use our own version until then.

[kylos101]

@sagor999 is there a PR for which we can inquire about the release? I ask because I think @jenting did similar last time...and then the release was cut rather quickly. 🙏

[jenting]

@sagor999 is there a PR for which we can inquire about the release? I ask because I think @jenting did similar last time...and then the release was cut rather quickly. 🙏

kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1017 (comment)

[kylos101]

Hi @jenting what release cycle do they generally follow, can you share a link? If none, can you reach out to Matt again?

[jenting]

Hi @jenting what release cycle do they generally follow, can you share a link? If none, can you reach out to Matt again?

v1.8.0-rc1 release
We could tried it at ephemeral cluster or workspace preview now 🚀

[jenting]

@sagor999 I have a question, if we would want to add custom labels to VolumeSnapshot, should we use the v1.8.0 release release?
Because I want to delete the VolumeSnapshot by labeling so we can remove the snapshots generated by the ephemeral cluster.

[sagor999]

Yeah, that is the only way or build our own version of it that has that commit.
It will also require creating separate snapshot classes, similar to how I did with storageClasses (as label is specified there).

[jenting]

It will also require creating separate snapshot classes, similar to how I did with storageClasses (as label is specified there).

If I understand correctly, creating separate volume snapshot classes with different labels.
The volume snapshot and volume snapshot content will inherit the labels from volume snapshot classes, correct?

[sagor999]

yup!

[jenting]

Yeah, that is the only way or build our own version of it that has that commit. It will also require creating separate snapshot classes, similar to how I did with storageClasses (as label is specified there).

I built it jenting/gcp-compute-persistent-disk-csi-driver:v1.8.0-rc1_linux_amd64, and I will try it tomorrow.

[sagor999]

@jenting probably no need to build you own version of it anymore: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/releases/tag/v1.8.0

[jenting]

@jenting probably no need to build you own version of it anymore: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/releases/tag/v1.8.0

The container image does not released 😢
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1056

[jenting]

I build our own jenting/gcp-compute-persistent-disk-csi-driver:v1.8.0