Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unnecessary navigation elements on error page shown when users can not join a team #10503

Open
gtsiolis opened this issue Jun 7, 2022 · 3 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 7, 2022

Bug description

Following up from #10309, when users trying to join a team and the invite URL has expired, the team menu on the navigation shows an extra empty element.

This is probably because of all the logical checks like https://github.com/gitpod-io/gitpod/pull/10309/files#diff-64248da95f399a1cfe99b03aa662caf313faf9b7016999111605da5d61f1971dR269.

There are possibly other pages that users could end up in this case. Maybe worth making the menu logic more explicit. 💭

1️⃣ (Deleted Team) 2️⃣ (Reset Invite URL) 3️⃣ (User Blocked) 4️⃣ (???)
Screenshot 2022-06-07 at 5 19 32 PM (2) Screenshot 2022-06-07 at 5 16 44 PM (2) Screenshot 2022-06-07 at 5 16 05 PM (2) Screenshot 2022-06-07 at 5 20 03 PM (2)

Steps to reproduce

Try joining a team after 1️⃣ deleting the team, 2️⃣ resetting the invite URL, 3️⃣ blocking the user, 4️⃣ etc.

Notice the 1 extra blank breadcrumb item and the 2 redundant tab menu below the team scope selector, which could be safely removed, see screenshot below.

Frame 1097

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@gtsiolis gtsiolis added type: bug Something isn't working component: dashboard team: webapp Issue belongs to the WebApp team help wanted labels Jun 7, 2022
@aboqasem
Copy link

aboqasem commented Jun 10, 2022

Hi!

What do the pictures demonstrate? Because if I understood correctly, they should show the extra element mentioned, but the team menu is not expanded.

Or do they show what are the possible errors that are leading to the extra element (you saw the empty element in these error states)?

Thank you for clarifying in advance!

@gtsiolis
Copy link
Contributor Author

Hello again, @aboqasem! Thanks for noticing. I've updated the issue description to clarify what's wrong with the screenshots and how to resolve this issue.

Notice the 1 extra blank breadcrumb item and the 2 redundant tab menu below the team scope selector, which could be safely removed, see screenshot below.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants