Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild only run when first time of project add into self-host Gitpod #10024

Closed
newbe36524 opened this issue May 15, 2022 · 7 comments
Closed
Assignees
Labels
type: bug Something isn't working

Comments

@newbe36524
Copy link

Bug description

I deploy a self-host Gitpod in Azure as https://github.com/gitpod-io/gitpod-microsoft-aks-guide says.

Everything works but some problem of prebuilds raised.

Prebuilds of DEFAULT branch only run at the first time when a new repo added as a project in gitpod. After that, when I make some changes on the DEFAULT branch, it doesn't trigger prebuild. it's always in the READY state. But the actual content is old.

I'm curious if I'm overlooking some configuration or if this is a bug.

Steps to reproduce

  1. install gitpod as https://github.com/gitpod-io/gitpod-microsoft-aks-guide says
  2. sign in self-host gitpod by github account
  3. add github intergration oauth permission with private_repo and repo
  4. add a private repo into gitrepo
  5. DEFAULT branch starts to run prebuild and get into READY state.
  6. edit README.md in the repo in DEFAULT branch and push
  7. prebuild stats is still READY but nothing run, and prebuild list view, there is nothing but the first record of prebuild when repo init.

Workspace affected

No response

Expected behavior

  1. when I push changes to DEFAULT branch, it would trigger prebuild.

Example repository

No response

Anything else?

No response

@AlexTugarev
Copy link
Member

@newbe36524, is there a .gitpod.yml in the default branch? Prebuilds are started on push events only if there are tasks in a .gitpod.yml file on the branch of the commit pushed.

You can run gp init to create a .gitpod.yml from template, just in case.

If there is/was none, we definitely need to improve the messaging to make it clear why a prebuild is running initially.
Also, then this is not a self-hosted bug. (cc. @lucasvaltl )

@jldec
Copy link
Contributor

jldec commented Jun 1, 2022

Will assume that this is a duplicate of https://github.com/gitpod-io/website/issues/2125 unless @newbe36524 confirms that there is an init task in the gitpod.yml on the default branch of this repo.

@newbe36524
Copy link
Author

newbe36524 commented Jun 2, 2022

@AlexTugarev @jldec
There is always a file named .gitpod.yml at the root of repo when I push new commint to my default branch 'main'

image: dfx_rust:bullseye-dfx-0.9.3-gitpod-5
ports:
  - port: 8000
    visibility: public
    onOpen: ignore
tasks:
  - name: dfx dev
    init: |
      . ~/fix_gitpod_path.sh
      cd src
      ./start.sh
      ./sh_setup_dev.sh
      ./sh_reinstall.sh
      dfx stop
    command: |
      . ~/fix_gitpod_path.sh
      pip3 install pipenv && \
      pip3 install pre-commit && \
      pre-commit install
      cd src
      ./start.sh
      ./sh_setup_dev.sh
vscode:
  extensions:
    - matklad.rust-analyzer
    - GitHub.copilot
    - panicbit.cargo
    - bungcip.better-toml
    - usernamehw.errorlens
    - ms-azuretools.vscode-docker
jetbrains:
  pycharm:
    plugins:
      - org.rust.lang
      - ru.adelf.idea.dotenv
      - com.chrisrm.idea.MaterialThemeUI
      - com.mallowigi

msedge_9oPsR3jjNT

But it never run again but the first time of project added to self-host gitpod

@lucasvaltl
Copy link
Contributor

👀 Thanks for sharing @newbe36524!
From my side, my repo has an (auto-generated) gitpod.yml file in it. Are the tasks in there enough to trigger a prebuild? Fwiw - I'm happy to spin up the self-hosted instance I used for this and give you access for testing - just ping me:)

@newbe36524
Copy link
Author

newbe36524 commented Jun 3, 2022

@lucasvaltl Sure, this is my host *******
It is worth noting that the first addition is triggered. But commit it again a second time will not.

@laushinka
Copy link
Contributor

laushinka commented Jun 9, 2022

So it turns out that we have deployed a fix a week ago in this PR, but self-hosted needs to update to the current main. @lucasvaltl Would you mind validating this by updating your installation to our main? 🙏🏽
Then we can close this issue 🙏🏽

@laushinka
Copy link
Contributor

I'll close it anyway as we are confident that this will be fixed once self-hosted is updated 💪🏼

Repository owner moved this from 🧊Backlog to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Jun 9, 2022
@laushinka laushinka moved this to Done in 🍎 WebApp Team Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

6 participants