From 63c3969740ac96783cdd3a75a0650f455d5536b5 Mon Sep 17 00:00:00 2001 From: Tarun Pothulapati Date: Mon, 4 Apr 2022 06:20:21 +0000 Subject: [PATCH] [installer] Displable `definitely-gp` by default Fixes https://github.com/gitpod-io/gitpod/issues/8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default - Update the airgap docs to remove a mention of this Signed-off-by: Tarun Pothulapati --- install/installer/docs/air-gap.md | 3 +-- install/installer/example-config.yaml | 2 +- install/installer/pkg/config/v1/config.go | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/install/installer/docs/air-gap.md b/install/installer/docs/air-gap.md index 20855cfa9cd5ea..278c86600f0da6 100644 --- a/install/installer/docs/air-gap.md +++ b/install/installer/docs/air-gap.md @@ -22,11 +22,10 @@ done ## Install Gitpod in Air-Gap Mode -To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step) and disable the `definitely-gp` feature. Add this to your Gitpod config: +To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step). Add this to your Gitpod config: ```yaml repository: your-registry.example.com -disableDefinitelyGp: true ``` That's it. Run the following commands as usual and Gitpod fetches the images from your registry and does not need internet access to operate: diff --git a/install/installer/example-config.yaml b/install/installer/example-config.yaml index c55a0416a7aaec..0f2b79be92d30d 100644 --- a/install/installer/example-config.yaml +++ b/install/installer/example-config.yaml @@ -10,7 +10,7 @@ containerRegistry: inCluster: true database: inCluster: true -disableDefinitelyGp: false +disableDefinitelyGp: true domain: "" kind: Full metadata: diff --git a/install/installer/pkg/config/v1/config.go b/install/installer/pkg/config/v1/config.go index 090eee253cb9b6..3dffe7d4cb2f35 100644 --- a/install/installer/pkg/config/v1/config.go +++ b/install/installer/pkg/config/v1/config.go @@ -54,7 +54,7 @@ func (v version) Defaults(in interface{}) error { cfg.Workspace.Runtime.ContainerDSocket = "/run/containerd/containerd.sock" cfg.Workspace.Runtime.ContainerDRuntimeDir = "/var/lib/containerd/io.containerd.runtime.v2.task/k8s.io" cfg.OpenVSX.URL = "https://open-vsx.org" - cfg.DisableDefinitelyGP = false + cfg.DisableDefinitelyGP = true return nil }