From 26b43b6cc9128e64e3e0332a31ae76fb8d7cd20e Mon Sep 17 00:00:00 2001 From: "Laurie T. Malau" Date: Wed, 15 Jun 2022 11:11:52 +0000 Subject: [PATCH] use prebuildlogs instead --- .../dashboard/src/components/PrebuildLogs.tsx | 3 +- .../dashboard/src/start/CreateWorkspace.tsx | 34 +++++++------- .../src/start/IntermediatePrebuildStatus.tsx | 22 +++++++++ components/dashboard/src/start/LogsView.tsx | 46 +++++++++++++++++++ .../dashboard/src/start/StartWorkspace.tsx | 9 +--- 5 files changed, 90 insertions(+), 24 deletions(-) create mode 100644 components/dashboard/src/start/IntermediatePrebuildStatus.tsx create mode 100644 components/dashboard/src/start/LogsView.tsx diff --git a/components/dashboard/src/components/PrebuildLogs.tsx b/components/dashboard/src/components/PrebuildLogs.tsx index af158827f3d49d..dc12ce28a422a9 100644 --- a/components/dashboard/src/components/PrebuildLogs.tsx +++ b/components/dashboard/src/components/PrebuildLogs.tsx @@ -19,7 +19,8 @@ import { getGitpodService } from "../service/service"; const WorkspaceLogs = React.lazy(() => import("./WorkspaceLogs")); export interface PrebuildLogsProps { - workspaceId?: string; + workspaceId: string | undefined; + logsEmitter?: EventEmitter; } export default function PrebuildLogs(props: PrebuildLogsProps) { diff --git a/components/dashboard/src/start/CreateWorkspace.tsx b/components/dashboard/src/start/CreateWorkspace.tsx index 9f964e8d65554f..a3cc747f3c11f7 100644 --- a/components/dashboard/src/start/CreateWorkspace.tsx +++ b/components/dashboard/src/start/CreateWorkspace.tsx @@ -5,12 +5,13 @@ */ import EventEmitter from "events"; -import React, { useEffect, Suspense, useContext, useState } from "react"; +import React, { useEffect, useContext, useState } from "react"; import { CreateWorkspaceMode, WorkspaceCreationResult, RunningWorkspacePrebuildStarting, ContextURL, + PrebuildWithStatus, } from "@gitpod/gitpod-protocol"; import { ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error"; import Modal from "../components/Modal"; @@ -25,8 +26,7 @@ import { watchHeadlessLogs } from "../components/PrebuildLogs"; import CodeText from "../components/CodeText"; import FeedbackComponent from "../feedback-form/FeedbackComponent"; import { isGitpodIo } from "../utils"; - -const WorkspaceLogs = React.lazy(() => import("../components/WorkspaceLogs")); +import LogsView from "./LogsView"; export interface CreateWorkspaceProps { contextUrl: string; @@ -462,6 +462,7 @@ interface RunningPrebuildViewProps { function RunningPrebuildView(props: RunningPrebuildViewProps) { const [logsEmitter] = useState(new EventEmitter()); + const [prebuild, setPrebuild] = useState(); useEffect(() => { const disposables = watchHeadlessLogs( @@ -480,6 +481,12 @@ function RunningPrebuildView(props: RunningPrebuildViewProps) { props.onPrebuildSucceeded(); } }, + onPrebuildUpdate(update: PrebuildWithStatus) { + console.log("we have prebuild update? ", update); + if (update.info) { + setPrebuild(update); + } + }, }), ); @@ -489,18 +496,13 @@ function RunningPrebuildView(props: RunningPrebuildViewProps) { }, []); return ( - - }> - - - - + ); } diff --git a/components/dashboard/src/start/IntermediatePrebuildStatus.tsx b/components/dashboard/src/start/IntermediatePrebuildStatus.tsx new file mode 100644 index 00000000000000..34c8a19bba2a8e --- /dev/null +++ b/components/dashboard/src/start/IntermediatePrebuildStatus.tsx @@ -0,0 +1,22 @@ +/** + * Copyright (c) 2022 Gitpod GmbH. All rights reserved. + * Licensed under the GNU Affero General Public License (AGPL). + * See License-AGPL.txt in the project root for license information. + */ + +import StatusRunning from "../icons/StatusRunning.svg"; + +function IntermediatePrebuildStatus() { + return ( +
+
+
+ + running +
+
+
+ ); +} + +export default IntermediatePrebuildStatus; diff --git a/components/dashboard/src/start/LogsView.tsx b/components/dashboard/src/start/LogsView.tsx new file mode 100644 index 00000000000000..1344ed3b80eb66 --- /dev/null +++ b/components/dashboard/src/start/LogsView.tsx @@ -0,0 +1,46 @@ +/** + * Copyright (c) 2022 Gitpod GmbH. All rights reserved. + * Licensed under the GNU Affero General Public License (AGPL). + * See License-AGPL.txt in the project root for license information. + */ + +import { Suspense } from "react"; +import EventEmitter from "events"; +import PrebuildLogs from "../components/PrebuildLogs"; +import { StartPage } from "./StartPage"; +import WorkspaceLogs from "../components/WorkspaceLogs"; +import { PrebuildWithStatus } from "@gitpod/gitpod-protocol"; +import { PrebuildStatus } from "../projects/Prebuilds"; +import IntermediatePrebuildStatus from "./IntermediatePrebuildStatus"; + +function LogsView(props: { + logsEmitter: EventEmitter; + workspaceId?: string; + shouldRunPrebuild?: boolean; + prebuild?: PrebuildWithStatus | undefined; + onIgnorePrebuild?: () => void; + isIntermediate?: boolean; +}) { + return ( + + }> + {props.shouldRunPrebuild ? ( + + ) : ( + + )} + + {props.shouldRunPrebuild && ( +
+ {props.prebuild && } + {!props.prebuild && props.isIntermediate && } + +
+ )} +
+ ); +} + +export default LogsView; diff --git a/components/dashboard/src/start/StartWorkspace.tsx b/components/dashboard/src/start/StartWorkspace.tsx index 0acd996503a099..afb0710b5179c0 100644 --- a/components/dashboard/src/start/StartWorkspace.tsx +++ b/components/dashboard/src/start/StartWorkspace.tsx @@ -29,6 +29,7 @@ import { getGitpodService, gitpodHostUrl } from "../service/service"; import { StartPage, StartPhase, StartWorkspaceError } from "./StartPage"; import ConnectToSSHModal from "../workspaces/ConnectToSSHModal"; import Alert from "../components/Alert"; +import LogsView from "./LogsView"; const sessionId = v4(); const WorkspaceLogs = React.lazy(() => import("../components/WorkspaceLogs")); @@ -736,11 +737,5 @@ function HeadlessWorkspaceView(props: { instanceId: string }) { }; }, []); - return ( - - }> - - - - ); + return ; }