Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opens multidiff view on open all changes from the home view #3758

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Nov 15, 2024

Description

Screen.Recording.2024-11-15.at.11.05.12.mov

The thing I don't like is that for each action click a new compare node is created. Do we need to clear the nodes somehow or search duplicates before adding?

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Nov 15, 2024 that may be closed by this pull request
@nzaytsev nzaytsev requested review from d13 and eamodio November 15, 2024 04:06
@d13 d13 force-pushed the features/3757-open-multidiff-view-on-open-changes-action-from-the-home-view branch from c1b4c37 to db33e05 Compare November 21, 2024 20:42
@d13 d13 merged commit 2a9e0b8 into main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open multidiff view on open changes action from the home view
2 participants