Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'#' encoded incorrectly #2014

Closed
jon-spotsource opened this issue May 31, 2022 · 4 comments
Closed

'#' encoded incorrectly #2014

jon-spotsource opened this issue May 31, 2022 · 4 comments
Assignees
@eamodio
Labels
bug Something isn't working verified ✔ Verified
Milestone
12.1

Comments

@jon-spotsource
Copy link

Issue Type: Bug

  1. Checkout branch feature/update-rush-to-use-heft-#182316041
  2. Run extension command GitLens: Open File on Remote

A tab is opened with URL https://github.com/jondpenton/cpu-servers/blob/feature/update-rush-to-use-heft-%2523182316041/rush.json#L17. This is encoded correctly, except for the #, which is encoded as %2523 instead of %23.

Extension version: 12.0.7
VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:20:04.972Z)
OS version: Darwin arm64 21.4.0
Restricted Mode: No
Remote OS version: Darwin x64 21.4.0

System Info
Item Value
CPUs Apple M1 (8 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 16.00GB (0.19GB free)
Process Argv --crash-reporter-id 835ed3f0-239d-4888-a329-c59420210f19
Screen Reader no
VM 0%
Item Value
Remote SSH: work-pc
OS Darwin x64 21.4.0
CPUs Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)
Memory (System) 16.00GB (0.02GB free)
VM 0%
A/B Experiments 
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30492333
vscaat:30438848
vsclangdf:30486550
@jondpenton
Copy link

jondpenton commented May 31, 2022 •
edited
Loading

Additional info in issue template, but left out by VSCode:

  • Git version: git version 2.32.0 (Apple Git-132)
GitLens debug logs: 

[2022-05-31 14:49:23.479] [  13e] GitUri.fromUri — he=Uri(file:///Users/jon/Documents/projects/cpuservers/rush.json)
[2022-05-31 14:49:23.479] [  13f] GitProviderService.getOrOpenRepository — s=Uri(file:///Users/jon/Documents/projects/cpuservers/rush.json)
[2022-05-31 14:49:23.479] [  140] GitProviderService.getRepository — s=Uri(file:///Users/jon/Documents/projects/cpuservers/rush.json)
[2022-05-31 14:49:23.479] [  140] GitProviderService.getRepository returned /Users/jon/Documents/projects/cpuservers • 0 ms
[2022-05-31 14:49:23.480] [  13f] GitProviderService.getOrOpenRepository returned /Users/jon/Documents/projects/cpuservers • 0 ms
[2022-05-31 14:49:23.480] [  13e] GitUri.fromUri returned GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers) • 0 ms
[2022-05-31 14:49:23.480] [  141] GitProviderService.getRemotesWithProviders — s=/Users/jon/Documents/projects/cpuservers
[2022-05-31 14:49:23.480] [  142] GitProviderService.getRepository — s=/Users/jon/Documents/projects/cpuservers
[2022-05-31 14:49:23.480] [  142] GitProviderService.getRepository returned /Users/jon/Documents/projects/cpuservers • 0 ms
[2022-05-31 14:49:23.480] [  141] GitProviderService.getRemotesWithProviders completed • 0 ms
[2022-05-31 14:49:23.480] [  143] GitProviderService.getBranch — s=/Users/jon/Documents/projects/cpuservers
[2022-05-31 14:49:23.480] [  144] LocalGitProvider.getBranch — e=/Users/jon/Documents/projects/cpuservers
[2022-05-31 14:49:23.480] [  145] LocalGitProvider.getBranches — e=/Users/jon/Documents/projects/cpuservers
[2022-05-31 14:49:23.481] [  145] LocalGitProvider.getBranches completed • 0 ms
[2022-05-31 14:49:23.481] [  144] LocalGitProvider.getBranch completed • 0 ms
[2022-05-31 14:49:23.481] [  143] GitProviderService.getBranch completed • 0 ms
[2022-05-31 14:49:23.505] [  146] GitProviderService.onWindowStateChanged — s=focused=false
[2022-05-31 14:49:23.505] [  146] GitProviderService.onWindowStateChanged completed • 0 ms
[2022-05-31 14:49:23.723] [  147] GitProviderService.getBlame — s=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), e={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:23.723] [  148] LocalGitProvider.getBlame — e=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), t={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:23.723] [  148] LocalGitProvider.getBlame Cache hit: 'blame'
[2022-05-31 14:49:23.723] [  148] LocalGitProvider.getBlame completed • 0 ms
[2022-05-31 14:49:23.723] [  147] GitProviderService.getBlame completed • 0 ms
[2022-05-31 14:49:23.725] [  149] GitProviderService.getBlame — s=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), e={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:23.725] [  14a] LocalGitProvider.getBlame — e=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), t={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:23.726] [  14a] LocalGitProvider.getBlame Cache hit: 'blame'
[2022-05-31 14:49:23.726] [  14a] LocalGitProvider.getBlame completed • 0 ms
[2022-05-31 14:49:23.726] [  149] GitProviderService.getBlame completed • 0 ms
[2022-05-31 14:49:25.439] [  14b] GitProviderService.onWindowStateChanged — s=focused=true
[2022-05-31 14:49:25.439] [  14b] GitProviderService.onWindowStateChanged completed • 0 ms
[2022-05-31 14:49:25.680] [  14c] GitProviderService.getBlame — s=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), e={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:25.680] [  14d] LocalGitProvider.getBlame — e=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), t={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:25.680] [  14d] LocalGitProvider.getBlame Cache hit: 'blame'
[2022-05-31 14:49:25.680] [  14d] LocalGitProvider.getBlame completed • 0 ms
[2022-05-31 14:49:25.680] [  14c] GitProviderService.getBlame completed • 0 ms
[2022-05-31 14:49:25.683] [  14e] GitProviderService.getBlame — s=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), e={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:25.683] [  14f] LocalGitProvider.getBlame — e=GitUri(file:///Users/jon/Documents/projects/cpuservers/rush.json repoPath=/Users/jon/Documents/projects/cpuservers), t={"uri":{"$mid":1,"fsPath":"/Users/jon/Documents/projects/cpuservers/rush.json","external":"file:///Users/jon/Documents/projects/cpuservers/rush.json","path":"/Users/jon/Documents/projects/cpuservers/rush.json","scheme":"file"},"fileName":"/Users/jon/Documents/projects/cpuservers/rush.json","isUntitled":false,"languageId":"jsonc","version":1,"isClosed":false,"isDirty":false,"eol":1,"lineCount":32}
[2022-05-31 14:49:25.684] [  14f] LocalGitProvider.getBlame Cache hit: 'blame'
[2022-05-31 14:49:25.684] [  14f] LocalGitProvider.getBlame completed • 0 ms
[2022-05-31 14:49:25.684] [  14e] GitProviderService.getBlame completed • 0 ms

There were no GitLens (Git) logs for this command.

@eamodio eamodio self-assigned this Jun 1, 2022
@eamodio eamodio added the bug Something isn't working label Jun 1, 2022
@eamodio eamodio added this to the 12.1 milestone Jun 1, 2022
@eamodio eamodio mentioned this issue Jun 1, 2022
Open
@eamodio eamodio closed this as completed in ab3a242 Jun 1, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jun 1, 2022
@eamodio
Copy link
Member

eamodio commented Jun 1, 2022

Caused by microsoft/vscode#85930, which I had to hack around for this scenario

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@jon-spotsource
Copy link
Author

@eamodio I installed the extension GitLens (Insiders) v2022.6.105 and the command GitLens: Open File on Remote works! 🎉

Thanks for the quick turnaround.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Milestone
12.1
Development

No branches or pull requests
3 participants
@eamodio @jondpenton @jon-spotsource