Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate feasibility of switching to proto-lens for protobuf serialization. #89

Closed
patrickt opened this issue Jun 4, 2019 · 2 comments · Fixed by #296
Closed

Investigate feasibility of switching to proto-lens for protobuf serialization. #89

patrickt opened this issue Jun 4, 2019 · 2 comments · Fixed by #296
Labels
libraries Related to dependencies/libs

Comments

@patrickt
Copy link
Contributor

patrickt commented Jun 4, 2019

For historical reasons, we depend on forked versions of proto3-suite and proto3-wire. It would be pretty ideal if we could switch to proto-lens, given its somewhat nicer API and the fact that we don’t use any gRPC features that proto3-suite provides.

@patrickt patrickt added the libraries Related to dependencies/libs label Jun 4, 2019
@patrickt
Copy link
Contributor Author

patrickt commented Jun 4, 2019

Obviously, we can’t break backwards compatibility here, so it needs to be done very carefully.

@jkachmar
Copy link
Contributor

jkachmar commented Jun 5, 2019

Relevant modules from proto-lens as they relate to RPC service declaration:

Since proto-lens provides a protoc plugin you may be able to use that directly instead of however the proto3-suite stuff gets generated.

From there, I imagine there’s enough information to generate any actual implementation code wiring those RPC definitions up to server/client handlers with TemplateHaskell or Generic derivation (to potentially avoid having to write more protoc stuff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries Related to dependencies/libs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants