[Schema Inaccuracy / Question] owner in #/components/schemas/repo-search-result-item/ and #/components/schemas/repository is nullable

[gr2m]

Schema Inaccuracy

Update: See comment below for #/components/schemas/repository

    repo-search-result-item:
      title: Repo Search Result Item
      description: Repo Search Result Item
      type: object
      properties:
        id:
          type: integer
        node_id:
          type: string
        name:
          type: string
        full_name:
          type: string
        owner:
          nullable: true
          allOf:
          - "$ref": "#/components/schemas/simple-user"
        # ...

Expected

I didn't expect it to be nullable. If it is for a good reason, can we add add a description explaining what the reason is?

ref octokit/types.ts#338

[creativecreatorormaybenot]

To add to that, this must have been changed in the last few days. I sadly cannot figure out in which commit since the Git diff (on GitHub) does not seem to work properly with these raw files (and blame does not work at all).

[gr2m]

The same problem exists in #/components/schemas/repository which is much worse because it is used much more widely

    repository:
      title: Repository
      description: A git repository
      type: object
      properties:
        id:
          description: Unique identifier of the repository
          example: 42
          type: integer
        node_id:
          type: string
          example: MDEwOlJlcG9zaXRvcnkxMjk2MjY5
        # ...
        owner:
          nullable: true
          allOf:
          - "$ref": "#/components/schemas/simple-user"
        # ...

[xuorig]

Does not appear possible to be null on both repository and minimal-repository. Fix is incoming. It appears to have been this way since the launch of this description however. Thanks folks.

[creativecreatorormaybenot]

Thank you so much @xuorig. It confuses me, however, because my CI started failing exactly with the Dependabot PR that updated the types at one point. I was also able to manually confirm this (my code had correct types with non-nullable owner before) 🤷

[gr2m]

Confirmed that it's fixed now, thanks @xuorig

@creativecreatorormaybenot @octokit/types should be updated within 10 minutes, the update is propagating right now

[gr2m]

@creativecreatorormaybenot there is another problem with the OpenAPI spec which can result in the owner property type to be optional. See the follow up at #486

[creativecreatorormaybenot]

@gr2m thank you so much!