Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jekyll-seo-tag #723

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Upgrade jekyll-seo-tag #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8557acf
Update jekyll-seo-tag specs
ain Oct 18, 2020
1f02284
Fix #722 locale not respected in og:locale
ain Oct 18, 2020
34b2057
Merge branch 'master' into upgrade-jekyll-seo-tag
ain Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github-pages/dependencies.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Dependencies
"jekyll-gist" => "1.5.0",
"jekyll-paginate" => "1.1.0",
"jekyll-coffeescript" => "1.1.1",
"jekyll-seo-tag" => "2.6.1",
"jekyll-seo-tag" => "2.7.1",
"jekyll-github-metadata" => "2.13.0",
"jekyll-avatar" => "0.7.0",
"jekyll-remote-theme" => "0.4.2",
Expand Down
1 change: 1 addition & 0 deletions spec/fixtures/jekyll-seo-tag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
title: Jekyll SEO Tag
locale: et_EE
---

{% seo %}
8 changes: 6 additions & 2 deletions spec/github-pages/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,12 @@ def rm_destination
end

context "jekyll-seo-tag" do
it "outputs the tag" do
expect(contents).to match("<title>Jekyll SEO Tag")
it "outputs title tag" do
expect(contents).to include("<title>Jekyll SEO Tag | pages-gem</title>")
end

it "outputs OpenGraph locale meta tag" do
expect(contents).to include("<meta property=\"og:locale\" content=\"et_EE\">")
end
end

Expand Down