Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions out of sync #810

Closed
4 tasks done
TWiStErRob opened this issue Jan 2, 2022 · 8 comments
Closed
4 tasks done

Versions out of sync #810

TWiStErRob opened this issue Jan 2, 2022 · 8 comments

Comments

@TWiStErRob
Copy link

Before submitting an issue, please be sure to

This issue affects

  • The site generated by GitHub Pages
  • Building sites locally

The GitHub Pages Gem is intended to help users replicate the GitHub Pages build environment locally.

What did you do (e.g., steps to reproduce)

Want to update my Gemfile to match GitHub's version.

What did you expect to happen?

Find the specific version GitHub uses at the moment.

What happened instead?

Confusion:

At this point I can't tell if the /versions/ page is outdated (August?!) or GitHub is not using the latest from its own project?!

Please clarify and update scripts/documentation to keep these 4 numbers in sync.

@TWiStErRob
Copy link
Author

Note: not having 222 and 223 on GitHub releases also means it's hard to see what's changed.

@parkr
Copy link
Contributor

parkr commented Jan 3, 2022

@yoannchaudet Hey! Is there a way to run a Page Build job on the pages.github.com site periodically? Maybe a GitHub Action could fire off the build? Many folks use https://pages.github.com/versions/ (and /versions.json) to understand what gems they should use to match GitHub Pages, so ideally the site is rebuilt whenever you launch a new version to Pages. Thank you!

@yoannchaudet
Copy link
Contributor

Hello here!

Thank you for pointing these inconsistencies, this was not intended.

Versions 222 and 223 did not include any changes relevant to the build process itself and just helped support https://github.blog/changelog/2021-12-16-github-pages-using-github-actions-for-builds-and-deployments-for-public-repositories/.

We should not be out of sync in so many locations! I'll make sure we update our procedure to release pages-gem so it does not happen again and so we clean stuff up in the next few days.

@parkr (hi!) yes! We can definitely automate the rebuilds for pages.github.com ❤️

@parkr
Copy link
Contributor

parkr commented Jan 3, 2022

@yoannchaudet Hi! Thank you so much! ❤️

@TWiStErRob
Copy link
Author

TWiStErRob commented Jan 3, 2022

Thanks @parkr for pointing to the right person!

And also for still being active around here after your departure to greener pastures. 🙇‍♂️💪

Thanks for committing to cleaning up the confusion @yoannchaudet!

@yoannchaudet
Copy link
Contributor

Forgot to close that with the last update. We should be in-sync everywhere or within a few hours during any upgrade.

@TWiStErRob
Copy link
Author

Confirmed. Release 227 just went out 5 hours ago and it's everywhere except https://pages.github.com/versions/ which is on 226. Deployment might take a while as you said.

@yoannchaudet
Copy link
Contributor

pages.github.com is updated every 6 hours so it's a matter of minutes now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants