Adding missing squares, 'sparkle', 'package', and 'back'. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renaming existing squares for consistency with sized naming convention.
Starting in Mountain Lion, the OS replaces certain non-emoji characters with their emoji equivalents. |
|
heh, merge it. ping me in CF so I can get you setup gem releases. need other people to be able to handle it if i'm away. |
juliamae
pushed a commit
that referenced
this pull request
Nov 16, 2012
Adding missing squares, 'sparkle', 'package', and 'back'.
Dogs and cats living together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these could perhaps be the last of the missing emoji.
There are a whole lotta squares in here, so I renamed the old white_square and black_square to their actual names, white_large_square and black_large_square, to be consistent with the new squares.
Added what's below.
Ordered:
I'm not sure why Safari is rendering the medium small squares with emoji, as there are existing unicode characters for them, but those are the right codes.
For the record, the difference between the large and medium BLACK squares is only the highlight and the difference between the large and medium WHITE squares is the color of the outline (maybe the highlight, too- it's hard to tell). However there is no size difference.