diff --git a/data/reusables/actions/schedule-delay.md b/data/reusables/actions/schedule-delay.md index 31d1d7785255..82c6129d68dd 100644 --- a/data/reusables/actions/schedule-delay.md +++ b/data/reusables/actions/schedule-delay.md @@ -1,5 +1,5 @@ {% note %} -Note: The `schedule` event can be delayed during periods of high loads of {% data variables.product.prodname_actions %} workflow runs. High load times include the start of every hour. To decrease the chance of delay, schedule your workflow to run at a different time of the hour. +Note: The `schedule` event can be delayed during periods of high loads of {% data variables.product.prodname_actions %} workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour. {% endnote %} diff --git a/package-lock.json b/package-lock.json index 233fd8e03a48..f79ce3d394be 100644 --- a/package-lock.json +++ b/package-lock.json @@ -152,7 +152,6 @@ "make-promises-safe": "^5.1.0", "mdast-util-gfm-table": "^1.0.7", "micromark-extension-gfm-table": "^1.0.5", - "minimatch": "^7.0.0", "mkdirp": "^2.1.3", "mockdate": "^3.0.5", "nock": "^13.2.7", diff --git a/package.json b/package.json index 2286653b3ebb..4b8ff68a71ed 100644 --- a/package.json +++ b/package.json @@ -154,7 +154,6 @@ "make-promises-safe": "^5.1.0", "mdast-util-gfm-table": "^1.0.7", "micromark-extension-gfm-table": "^1.0.5", - "minimatch": "^7.0.0", "mkdirp": "^2.1.3", "mockdate": "^3.0.5", "nock": "^13.2.7", diff --git a/tests/meta/repository-references.js b/tests/meta/repository-references.js index c3002582570d..bdcae10d2149 100644 --- a/tests/meta/repository-references.js +++ b/tests/meta/repository-references.js @@ -1,7 +1,6 @@ import fs from 'fs' import walkSync from 'walk-sync' -import minimatch from 'minimatch' /* This test exists to make sure we don't reference private GitHub owned repositories @@ -10,9 +9,7 @@ in our open-source repository. If this test is failing... (1) edit the file to remove the reference; or (2) the repository is public, - add the repository name to PUBLIC_REPOS; or -(3) the file references a docs repository, - add the file name to ALLOW_DOCS_PATHS. + add the repository name to PUBLIC_REPOS. */ // These are a list of known public repositories in the GitHub organization. @@ -72,21 +69,6 @@ const PUBLIC_REPOS = new Set([ 'gh-migration-analyzer', ]) -const ALLOW_DOCS_PATHS = [ - '.github/actions-scripts/enterprise-server-issue-templates/*.md', - '.github/review-template.md', - '.github/workflows/hubber-contribution-help.yml', - '.github/workflows/sync-search-indices.yml', - '.github/workflows/site-policy-reminder.yml', - 'contributing/search.md', - 'docs/index.yaml', - 'lib/excluded-links.js', - 'ownership.yaml', - 'script/README.md', - 'script/toggle-ghae-feature-flags.js', - 'script/i18n/clone-translations.sh', -] - // This regexp will capture the last segment of a GitHub repo name. // E.g., it will capture `backup-utils.git` from `https://github.com/github/backup-utils.git`. const REPO_REGEXP = /\/\/github\.com\/github\/([\w\-.]+)/gi @@ -139,11 +121,7 @@ describe('check if a GitHub-owned private repository is referenced', () => { // The referenced repo may or may not end with '.git', so ignore that extension. .map(([, repoName]) => repoName.replace(/\.git$/, '')) .filter((repoName) => !PUBLIC_REPOS.has(repoName)) - .filter((repoName) => { - return !( - repoName.startsWith('docs') && ALLOW_DOCS_PATHS.some((path) => minimatch(filename, path)) - ) - }) + .filter((repoName) => !repoName.startsWith('docs')) expect( matches, `This test exists to make sure we don't reference private GitHub owned repositories in our open-source repository. @@ -153,8 +131,7 @@ describe('check if a GitHub-owned private repository is referenced', () => { You can: (1) edit the file to remove the repository reference; or - (2) if the repository is public, add the repository name to the 'PUBLIC_REPOS' variable in this test file; or - (3) if the file references a docs repository, add the file name to the 'ALLOW_DOCS_PATHS' variable in this test file.` + (2) if the repository is public, add the repository name to the 'PUBLIC_REPOS' variable in this test file.` ).toHaveLength(0) }) })