Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting-up-your-development-environment-to-create-a-github-app.md #1369

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Update setting-up-your-development-environment-to-create-a-github-app.md #1369

merged 4 commits into from
Dec 2, 2020

Conversation

macedogm
Copy link
Contributor

@macedogm macedogm commented Nov 15, 2020

Why:

Fix two small typos in the documentation.

What's being changed:

  1. You'll won't -> You won't
  2. I'm getting seeing -> I'm getting

Check off the following:

@welcome
Copy link

welcome bot commented Nov 15, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@macedogm Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 16, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 24, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 24, 2020
@janiceilene
Copy link
Contributor

This is not stale! @macedogm Thank you for your patience as our small team works through the amazing contributions ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 1, 2020
@shati-patel shati-patel self-assigned this Dec 2, 2020
@shati-patel shati-patel removed the stale There is no recent activity on this issue or pull request label Dec 2, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😄 Thank you for the fix, @macedogm! We really appreciate all the community contributions to help us improve our docs 🎉

I'll get this merged shortly!

@shati-patel shati-patel merged commit b432846 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@macedogm
Copy link
Contributor Author

macedogm commented Dec 2, 2020

Oops 😄 Thank you for the fix, @macedogm! We really appreciate all the community contributions to help us improve our docs 🎉

I'll get this merged shortly!

Thanks for reviewing and merging @shati-patel !

This was referenced Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants