Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm dependabot documentation incorrect #34495

Closed
1 task done
jamescrowley opened this issue Sep 5, 2024 · 4 comments
Closed
1 task done

pnpm dependabot documentation incorrect #34495

jamescrowley opened this issue Sep 5, 2024 · 4 comments
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review

Comments

@jamescrowley
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/enterprise-cloud@latest/code-security/dependabot/ecosystems-supported-by-dependabot/supported-ecosystems-and-repositories

What part(s) of the article would you like to see updated?

This section:
Screenshot 2024-09-05 at 10 36 57

shows security updates being supported for pnpm v7,8,9, but security updates are not supported for pnpm v9 (apparently GitHub has an internal ticket tracking this)

Also flagged here: dependabot/dependabot-core#10534

Additional information

No response

@jamescrowley jamescrowley added the content This issue or pull request belongs to the Docs Content team label Sep 5, 2024
Copy link

welcome bot commented Sep 5, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 5, 2024
@nguyenalex836 nguyenalex836 added enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 5, 2024
@nguyenalex836
Copy link
Contributor

@jamescrowley Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@subatoi
Copy link
Contributor

subatoi commented Sep 6, 2024

@jamescrowley 👋 Thank you for this—for raising it and for the fact that you raised an issue first.

I've confirmed you're absolutely right, so we need to fix this. We're in a bit of an unusual situation as we're freezing the docs repo next week for one week, so I wanted to get this fix in as soon as possible rather than opening it up to contributors. I thought about adding you as a co-committer but I noticed you don't make use of the no-reply email function in your commits, so I didn't want to go ahead and do that without your permission.

You'll notice this issue close shortly when we merge in the fix internally, and the docs will reflect the change shortly thereafter.

Please do know that we really appreciate your help here—I'll just cc in @nguyenalex836 for 👀 as well.

@subatoi subatoi closed this as completed Sep 6, 2024
@jamescrowley
Copy link
Author

Cheers @subatoi 🙏 I didn’t actually know about the no-reply email option on github so thanks for sharing that too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants