Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn3 publish command #24811

Closed
1 task done
hindicator opened this issue Apr 1, 2023 · 5 comments · Fixed by #26054
Closed
1 task done

Yarn3 publish command #24811

hindicator opened this issue Apr 1, 2023 · 5 comments · Fixed by #26054
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue packages This issue or pull request should be reviewed by the docs packages team

Comments

@hindicator
Copy link

hindicator commented Apr 1, 2023

Code of Conduct

What article on docs.github.com is affected?

content\actions\publishing-packages\publishing-nodejs-packages.md

What part(s) of the article would you like to see updated?

// For Yarn3 use -
// yarn npm publish

  • run: yarn publish

lines 180 - 183

Additional information

I should fork the repo only for such a small suggestion instead of branch push and PR ?
I believe the comment fits, your choice.
Have a great day =).

@hindicator hindicator added the content This issue or pull request belongs to the Docs Content team label Apr 1, 2023
@welcome
Copy link

welcome bot commented Apr 1, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 1, 2023
@cmwilson21
Copy link
Contributor

@hindicator Thanks for opening an issue! We have instructions for Yarn included. Would you mind clarifying the change you are suggesting?

@cmwilson21 cmwilson21 added more-information-needed More information is needed to complete review and removed triage Do not begin working on this issue until triaged by the team labels Apr 3, 2023
@hindicator
Copy link
Author

hindicator commented Apr 3, 2023

@cmwilson21
Yarn 3 command for publish is
yarn npm publish
Unlike the written command yarn publish
So my suggestion is to add a comment before, mentioning this.

@github-actions github-actions bot removed the more-information-needed More information is needed to complete review label Apr 3, 2023
@cmwilson21
Copy link
Contributor

Gotcha! Thank you for clarifying! I see the difference now 😄

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added actions This issue or pull request should be reviewed by the docs actions team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review labels Apr 4, 2023
@skedwards88
Copy link
Contributor

Thanks for opening this issue! It looks like Yarn 1 is not being maintained, so I would be ok with updating this example to use yarn npm publish (which was introduced in Yarn 2), and adding a comment to use yarn publish for Yarn 1. (Basically just the inverse of what you recommended.) e.g. something like

      - run: yarn
      - run: yarn npm publish // for Yarn version 1, use `yarn publish` instead

You or anyone else is welcome to open a PR with this change.

@skedwards88 skedwards88 added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels May 12, 2023
@PaoloJr90 PaoloJr90 mentioned this issue Jun 16, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@skedwards88 @hindicator @cmwilson21 and others