Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a go to top button #1894

Closed
siddhantvirus opened this issue Dec 8, 2020 · 11 comments
Closed

Add a go to top button #1894

siddhantvirus opened this issue Dec 8, 2020 · 11 comments
Assignees
Labels
design Will involve design/engineering engineering Will involve Docs Engineering

Comments

@siddhantvirus
Copy link

What is the current behavior?

Currently, there are no buttons to let a reader scroll back to the Table of Contents on any page on docs.github.com.
While this can be bypassed by a desktop/laptop by using the home button, users using a mobile device do not have the same privilege

What changes are you suggesting?

I suggest adding a floating button on the bottom right corner at least the mobile view of the website which when clicked either takes the user back to the top of the page , or can be a linked to the href of the table of contents heading.

Additional information

I believe the approach needs to be such , that it can be enabled on only the pages with actual documentation and that it doesn't need to be manually added for every markdown page.

@siddhantvirus siddhantvirus added the engineering Will involve Docs Engineering label Dec 8, 2020
@welcome
Copy link

welcome bot commented Dec 8, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 8, 2020
@janiceilene
Copy link
Contributor

@siddhantvirus Thanks for opening an issue! I'll triage this for the right team to take a look 👀

@janiceilene janiceilene added the design Will involve design/engineering label Dec 8, 2020
@Ylan-sayada
Copy link

Is someone work on this issue?
I'm interested to contribute on the code part(if the design part is already defined).

@janiceilene
Copy link
Contributor

👋 @Ylan-sayada We don't have any design specs created for this issue 💛 If you're looking for somewhere to contribute, there are quite a few issues with a help wanted label ✨

@siddhantvirus
Copy link
Author

siddhantvirus commented Dec 11, 2020

@janiceilene could you please look into to why there are two random spammy comments on this issue from accounts which don't seem to have any actual activity whatsoever?
This seems to be highly suspicious and I can't seem to find other issues where the said users have done the same.
Honestly I feel a little scared at this point.

@ghost

This comment has been minimized.

@siddhantvirus
Copy link
Author

@FREELANCEGITIT ? I'm sorry but i wasn't referring to you in any of my comments 😅

@janiceilene
Copy link
Contributor

@siddhantvirus I'm not sure why that was happening, but they should all be removed and reported now 💛

@kazuhitonakayama
Copy link
Contributor

kazuhitonakayama commented Dec 20, 2020

Hi , Nice to meet you.
I also want to contribute this issue...

Could I work on this issue with you??

If it would be good, what we will have to do is below?
・Make design idea
・do the code part

I would be happy to receive your reply!!
@Ylan-sayada @janiceilene

@chiedo chiedo added open PR and removed triage Do not begin working on this issue until triaged by the team labels Jan 5, 2021
@kazuhitonakayama
Copy link
Contributor

Happy New Year , every one!
I'm working on this issue at PR( #2243 ).

@heiskr
Copy link
Contributor

heiskr commented Mar 25, 2021

Happened in #2243

@heiskr heiskr closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Will involve design/engineering engineering Will involve Docs Engineering
Projects
None yet
Development

No branches or pull requests

14 participants
@simpsoka @heiskr @chiedo @janiceilene @siddhantvirus @kazuhitonakayama @Ylan-sayada and others