LGTM.com - false positive - 'noqa' suppression comments

[DimitriPapadopoulos]

Description of the false positive

LGTM.com rightfully complains that the Except block handles 'BaseException'. No worries here.

This issue is about suppression comments. Each linter comes with its own snytax:

• noqa:E722 for Flake8
• lgtm [py/catch-base-exception] for LGTM.com

Adding a different comment for each linter may end up with long and confusing lines of code. The standard for Python is Flake8 and its noqa comments. It would make sense to support Flake8 suppression comments in addition to LGTM.com suppression comments, when possible.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/nilearn/nilearn/snapshot/0cd925e33787e277990b524efeba0c8125d04816/files/nilearn/datasets/func.py?sort=name&dir=ASC&mode=heatmap#x38df926fe033f5ae:1

[tausbn]

It should already be possible to use noqa as a suppression comment on LGTM.com, exactly for the reasons you specify.

(Implemented here: https://github.com/github/codeql/blob/main/python/ql/src/analysis/AlertSuppression.ql#L74)

[tausbn]

Ah, I should mention that this only works for the undecorated noqa form, not the one that mentions a specific rule. This is why it isn't working currently in the link you give above.

[DimitriPapadopoulos]

Thanks for the link. While it's not a small endeavour to link Flake8 error codes to LGTM.com ones, when possible, it would be a worthwhile addition.

In the short term, you could detect \\s*noqa:E in addition to \\s*noqa\\s*.

[DimitriPapadopoulos]

Undecorated noqa doesn't work either:
https://lgtm.com/projects/g/bids-standard/bids-specification/snapshot/56824aa6b869bcbec1fb14c50e3771cfc0358af5/files/pdf_build_src/process_markdowns.py?sort=name&dir=ASC&mode=heatmap#xea83c650d9db5491:1