Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop printing all output twice. #844

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Stop printing all output twice. #844

merged 2 commits into from
Dec 13, 2021

Conversation

chrisgavin
Copy link
Contributor

@chrisgavin chrisgavin commented Dec 9, 2021 •
edited
Loading

Maybe I'm missing some reason for this code existing, but it feels like all it does is duplicate the extractor output in the Actions logs. Can we remove it or have I missed something here?

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@chrisgavin chrisgavin requested a review from a team as a code owner December 9, 2021 13:27
@chrisgavin
Copy link
Contributor Author

Here's a somewhat noisy but hopefully still useful diff showing the effect of the change on a JavaScript build. https://www.diffchecker.com/GQYzoaIw

@chrisgavin chrisgavin enabled auto-merge December 13, 2021 11:44
@chrisgavin chrisgavin merged commit 716b598 into main Dec 13, 2021
@chrisgavin chrisgavin deleted the duplicated-output branch December 13, 2021 11:57
@github-actions github-actions bot mentioned this pull request Jan 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmakholm hmakholm hmakholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgavin @hmakholm