Analyze: Improve log grouping and log the analysis summary in its own group #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix grouping of the analysis logs, so that custom query logs also get grouped. Capture the stdout of codeql database analyze, which contains the analysis summary from summary and diagnostic queries. Log this output in its own group, along with the baseline computed in the Action.
adityasharad
force-pushed
the
analyze/summary-logging
branch
from
25be569 to
741bd73
Compare
aeisenberg
reviewed
May 20, 2021
As produced by npm ci && npm run removeNPMAbsolutePaths.
aeisenberg
approved these changes
May 20, 2021
aibaars
reviewed
May 26, 2021
| @@ -717,7 +717,7 @@ function getCodeQLForCmd(cmd: string): CodeQL { | |||
| await new toolrunner.ToolRunner(cmd, args, { | |||
| listeners: { | |||
| stdout: (data: Buffer) => { | |||
| output += data.toString(); | |||
| output += data.toString("utf8"); | |||
There was a problem hiding this comment.
@adityasharad Is CodeQL guaranteed to output UTF-8 ? Doesn't it output things in the "system" encoding to make sure things render correctly when running in a non-UTF-8 terminal?
There was a problem hiding this comment.
Good point, it uses the Java default, so that's a little harder to anticipate here. Is it better to just avoid passing in a locale?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeql database analyze, which contains the analysis summary from summary and diagnostic queries. Log this output in its own group, along with the baseline metrics computed in the Action.Merge / deployment checklist