Automatically clean up old TRAP caches #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we'll only cleanup when running on the default branch
aeisenberg
reviewed
May 24, 2024
Comment on lines
+241
to
+246
| { | ||
| id: 7, | ||
| key: "codeql-trap-1-2.0.0-swift-older", | ||
| created_at: "2024-02-21T14:25:00Z", | ||
| size_in_bytes: 300 * 1024 * 1024, | ||
| }, |
There was a problem hiding this comment.
This one wasn't deleted. Is it because the timestamp is identical to id 6? Wait...the code should only keep one cache per language. So, I'm not sure what's going on here.
There was a problem hiding this comment.
Ah, I see now that the reasoning for this is a bit opaque without looking at the rest of the file. We're expecting to only clean up TRAP caches for JavaScript and Ruby as these are the only ones that the getTestConfigWithTempDir config specifies as languages to analyze in this job. I'll add a comment to make this clearer.
There was a problem hiding this comment.
Thanks. That makes a lot of sense.
aeisenberg
approved these changes
May 24, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new feature, behind a flag, that keeps only the newest TRAP cache for each language.
We call the Actions cache APIs directly as these have not yet been added to the
@actions/cachenpm package.I have added a unit test exercising most of the functionality, and have also tested this manually using a test repo. I think an integration test is probably not worth it, particularly on this repo where the databases are small enough that TRAP caching skips the upload anyway.
Merge / deployment checklist