Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better error messages when determining merge-base #1860

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Add better error messages when determining merge-base #1860

merged 4 commits into from
Aug 29, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Aug 28, 2023 •
edited
Loading

Avoid printing scary error messages to console when the current directory is not a git repo. Instead provide a better reason for the git failure and continue on.

Fixes #1162.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner August 28, 2023 19:29
@aeisenberg aeisenberg force-pushed the aeisenberg/better-error-messages branch 6 times, most recently from 723ff68 to eb92954 Compare August 28, 2023 22:35
@aeisenberg
Add better error messages when determining merge-base
d721f69 
Avoid printing scary error messages to console when the current
directory is not a git repo. Instead provide a better reason for the git
failure and continue on.
@aeisenberg aeisenberg force-pushed the aeisenberg/better-error-messages branch from eb92954 to d721f69 Compare August 28, 2023 22:50
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 28, 2023
View reviewed changes
src/actions-util.test.ts Fixed Show resolved Hide resolved
henrymercer
henrymercer reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor suggestions. Also I've been suggesting we add changelog notes to more of our PRs and I think this one would benefit from one too.

src/actions-util.test.ts Outdated Show resolved Hide resolved
src/actions-util.ts Outdated Show resolved Hide resolved
src/actions-util.ts Outdated Show resolved Hide resolved
src/actions-util.ts Outdated Show resolved Hide resolved
src/actions-util.test.ts Fixed Show resolved Hide resolved
src/actions-util.ts Outdated Show resolved Hide resolved
henrymercer
henrymercer previously approved these changes Aug 29, 2023
View reviewed changes
src/actions-util.test.ts Outdated Show resolved Hide resolved
src/actions-util.test.ts Outdated Show resolved Hide resolved
src/actions-util.ts Outdated Show resolved Hide resolved
henrymercer
henrymercer approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for addressing this bit of customer feedback!

@aeisenberg aeisenberg enabled auto-merge August 29, 2023 20:24
@aeisenberg aeisenberg merged commit c5acfe3 into main Aug 29, 2023
344 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/better-error-messages branch August 29, 2023 20:51
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid printing an error message when upload-sarif location is not a git directory
2 participants
@aeisenberg @henrymercer