Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum CodeQL version to 2.9.4 #1724

Merged
merged 10 commits into from
Jul 17, 2023
Merged

Bump minimum CodeQL version to 2.9.4 #1724

merged 10 commits into from
Jul 17, 2023

Conversation

henrymercer
Copy link
Contributor

Now that GHES 3.5 is deprecated, we bump the minimum CodeQL version supported by the Action to 2.9.4.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner June 12, 2023 10:40
@henrymercer henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 30ba2dc to b5a2e41 Compare June 12, 2023 11:06
@henrymercer henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 8b03018 to 9f45792 Compare June 12, 2023 12:28
aeisenberg
aeisenberg previously approved these changes Jun 12, 2023
View reviewed changes
angelapwen
angelapwen previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I seem to remember that we wanted to improve our communication of bumping the minimum CLI version prior to the Actions release where we deprecate it. I'll backlink the internal issue.

@henrymercer
Copy link
Contributor Author

The deprecation date for GHES 3.5 changed, so we should hold off on merging this until the new date passes.

@henrymercer henrymercer mentioned this pull request Jul 7, 2023
Merged
@henrymercer henrymercer dismissed stale reviews from angelapwen and aeisenberg via 4149476 July 10, 2023 12:16
@henrymercer
Copy link
Contributor Author

henrymercer commented Jul 10, 2023 •
edited
Loading

I plan to merge this after the CodeQL Action release associated with CodeQL 2.14.0 has completed. We can then wait a week until we release this to give users who are still using the deprecated CLIs time to see the warnings and update.

@henrymercer henrymercer force-pushed the henrymercer/bump-minimum-codeql-version branch from 4149476 to fed4586 Compare July 10, 2023 12:21
@henrymercer henrymercer requested a review from angelapwen July 11, 2023 12:16
angelapwen
angelapwen previously approved these changes Jul 11, 2023
View reviewed changes
@henrymercer henrymercer requested a review from angelapwen July 14, 2023 15:33
@henrymercer henrymercer merged commit 2ff6d83 into main Jul 17, 2023
@henrymercer henrymercer deleted the henrymercer/bump-minimum-codeql-version branch July 17, 2023 12:32
This was referenced Jul 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

@aeisenberg aeisenberg aeisenberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrymercer @aeisenberg @angelapwen