python-setup: Handle poetry virtualenvs.options.no-pip = true
#1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Dec 9, 2022
aeisenberg
reviewed
Dec 12, 2022
| @@ -88,6 +88,8 @@ async function setupPythonExtractor(logger: Logger) { | |||
| return; | |||
| } | |||
|
|
|||
| const scriptsFolder = path.resolve(__dirname, "../python-setup"); | |||
There was a problem hiding this comment.
You will need to rebuild the javascript files in order to get this to pass.
RasmusWL
force-pushed
the
rasmuswl/poetry-always-install-pip
branch
from
0bcae85 to
c2e3666
Compare
|
Hmmm...at least one of the failing tests may point to a legitimate problem: https://github.com/github/codeql-action/actions/runs/3705092268/jobs/6278570030#step:7:29 |
RasmusWL
force-pushed
the
rasmuswl/poetry-always-install-pip
branch
from
c2e3666 to
4bd9723
Compare
|
🤔 maybe I should have not rebased, so the old actions runs were still linked from the commits 🤔 anyway, good that the comment from Also 🙈 on the fact that it took this many attempts to get it right |
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1425
Merge / deployment checklist