-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scans with packs for languages not being scanned #1116
Conversation
src/config-utils.ts
Outdated
@@ -1168,7 +1168,8 @@ export function parsePacksFromConfig( | |||
throw new Error(getPacksInvalid(configFile)); | |||
} | |||
if (!languages.includes(lang as Language)) { | |||
throw new Error(getPacksRequireLanguage(lang, configFile)); | |||
// This particular language is not being analyzed in this run. | |||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that we won't fail on the pack with the wrong language, but we won't attempt to run the pack below either, right? A comment to that effect would be great.
6cc8292
to
4e14024
Compare
Currently failing on the nightly builds. These should be fixed by github/codeql#9667. I am currently building a nightly release that should contain the fix. |
Previously, we were being too strict about checking that a pack's language was being scanned. It was a failure if a pack language was specified for a language not being scanned.
4e14024
to
1653a84
Compare
@adityasharad can I get another look at this PR from you? I'd like to get this in the next release. |
Previously, we were being too strict about checking that a pack's
language was being scanned. It was a failure if a pack language
was specified for a language not being scanned.
Merge / deployment checklist