Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False warning for commit merged pr #1624

Closed
AnnAngela opened this issue Mar 29, 2023 · 2 comments
Closed

False warning for commit merged pr #1624

AnnAngela opened this issue Mar 29, 2023 · 2 comments

Comments

@AnnAngela
Copy link

In the commit that merged PR, codeql reports a warning (example):

Warning: 1 issue was detected with this workflow: Using on.push.paths can prevent Code Scanning annotating new alerts in your pull requests.

But my workflow file contains on.push.paths. How can I remove the warning?

@aibaars
Copy link
Collaborator

aibaars commented Mar 29, 2023

Thanks for reporting this. The warning is obsolete these days and #1625 should stop it from being reported.

In the past, CodeScanning compared the alerts found on a pull request branch to the alerts found previously on the "base" branch (a baseline) to determine which alerts were introduced by the pull request, which alerts were already present, and which alerts were fixed as a result of the pull request. If you had restrictions on the on.push trigger then it was more likely that the baseline for comparison is outdated or even missing.

Recently, CodeScanning switched to simpler strategy for determining which alerts to display in a pull request. The new strategy no longer relies on a baseline, so the warning has become obsolete.

@AnnAngela
Copy link
Author

Thanks for reporting this. The warning is obsolete these days and #1625 should stop it from being reported.

In the past, CodeScanning compared the alerts found on a pull request branch to the alerts found previously on the "base" branch (a baseline) to determine which alerts were introduced by the pull request, which alerts were already present, and which alerts were fixed as a result of the pull request. If you had restrictions on the on.push trigger then it was more likely that the baseline for comparison is outdated or even missing.

Recently, CodeScanning switched to simpler strategy for determining which alerts to display in a pull request. The new strategy no longer relies on a baseline, so the warning has become obsolete.

THX A LOT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants