Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: URI malformed should report the input / offset #1542

Closed
jsoref opened this issue Feb 17, 2023 · 2 comments · Fixed by #1694
Closed

Error: URI malformed should report the input / offset #1542

jsoref opened this issue Feb 17, 2023 · 2 comments · Fixed by #1694

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 17, 2023

Fwiw, I've been using the same workflow for months now, so I don't see why it would suddenly change its behavior. That said, it doesn't really matter why it changed whether it's my code or the library's code. It would be very helpful to any user of this action if it were to report at least the URI it didn't like, and, if at all possible, the source of the URI.

https://github.com/check-spelling/sdk-ng/actions/runs/4200335289/jobs/7286246387

Download action repository 'github/codeql-action@v2' (SHA:17573ee1cc1b9d061760f3a006fc4aac4f944fd5)

Run github/codeql-action/upload-sarif@v2

Uploading results
Processing sarif files: ["/tmp/tmp.cTD1j4ui9R.sarif.json"]
Error: URI malformed
URIError: URI malformed
at decodeURIComponent ()
at resolveUriToFile (/home/runner/work/_actions/github/codeql-action/v2/lib/fingerprints.js:197:15)
at Object.addFingerprints (/home/runner/work/_actions/github/codeql-action/v2/lib/fingerprints.js:251:30)
at uploadFiles (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:245:32)
at Object.uploadFromActions (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:136:18)
at async run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:48:30)
at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:70:9)

possible uris?

jq . tmp.cTD1j4ui9R.sarif.json|grep '"uri"'|perl -pe 's/,$//;s/^\s*"uri": //;s/"//g'|sort -u:

.github/workflows/ci.yml
.github/workflows/release.yml
.gitmodules
README.md
cmake/Zephyr-sdkConfig.cmake
cmake/Zephyr-sdkConfigVersion.cmake
cmake/zephyr/Kconfig
cmake/zephyr/generic.cmake
cmake/zephyr/host-tools.cmake
cmake/zephyr/target.cmake
cmake/zephyr_sdk_export.cmake
configs/aarch64-zephyr-elf.config
configs/arc-zephyr-elf.config
configs/arm-zephyr-eabi.config
configs/mips-zephyr-elf.config
configs/nios2-zephyr-elf.config
configs/riscv64-zephyr-elf.config
configs/sparc-zephyr-elf.config
configs/x86_64-zephyr-elf.config
configs/xtensa-espressif_esp32_zephyr-elf.config
configs/xtensa-espressif_esp32s2_zephyr-elf.config
configs/xtensa-intel_apl_adsp_zephyr-elf.config
configs/xtensa-intel_s1000_zephyr-elf.config
configs/xtensa-nxp_imx8m_adsp_zephyr-elf.config
configs/xtensa-nxp_imx_adsp_zephyr-elf.config
meta-zephyr-sdk/README.md
meta-zephyr-sdk/conf/distro/include/zephyr-sdk.inc
meta-zephyr-sdk/conf/distro/zephyr-sdk.conf
meta-zephyr-sdk/conf/layer.conf
meta-zephyr-sdk/files/additional-licenses/DABAEZ
meta-zephyr-sdk/files/additional-licenses/SHUMATECH
meta-zephyr-sdk/recipes-core/expat/expat_%.bbappend
meta-zephyr-sdk/recipes-core/udev/eudev_%.bbappend
meta-zephyr-sdk/recipes-devtools/arc_qemu/arc-qemu_git.bb
meta-zephyr-sdk/recipes-devtools/arc_qemu/files/cross.patch
meta-zephyr-sdk/recipes-devtools/meson/meson.inc
meta-zephyr-sdk/recipes-devtools/meson/meson/0001-Make-CPU-family-warnings-fatal.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/0001-gtkdoc-fix-issues-that-arise-when-cross-compiling.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/0001-is_debianlike-always-return-False.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/0001-python-module-do-not-manipulate-the-environment-when.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/0002-Support-building-allarch-recipes-again.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/disable-rpath-handling.patch
meta-zephyr-sdk/recipes-devtools/meson/meson/meson-setup.py
meta-zephyr-sdk/recipes-devtools/meson/meson/meson-wrapper
meta-zephyr-sdk/recipes-devtools/meson/meson_0.59.3.bb
meta-zephyr-sdk/recipes-devtools/meson/nativesdk-meson_0.59.3.bb
meta-zephyr-sdk/recipes-devtools/qemu/files/cross.patch
meta-zephyr-sdk/recipes-devtools/qemu/zephyr-qemu_git.bb
meta-zephyr-sdk/recipes-devtools/xilinx_qemu/files/0001-Revert-target-arm-Revert-back-to-YIELD-for-WFI.patch
meta-zephyr-sdk/recipes-devtools/xilinx_qemu/files/0002-Enable-WFI-CPU-halting-in-icount-mode.patch
meta-zephyr-sdk/recipes-devtools/xilinx_qemu/xilinx-qemu_git.bb
meta-zephyr-sdk/recipes-hosttools/bossa/bossa_git.bb
meta-zephyr-sdk/recipes-hosttools/bossa/files/0001-Flash.h-Add-flash-override-samba-error.patch
meta-zephyr-sdk/recipes-hosttools/bossa/files/0001-Wait-for-EEFC-flash-to-complete-operations-before-re.patch
meta-zephyr-sdk/recipes-hosttools/bossa/files/0002-CalwFlash-Add-SAM4L-Flashcalw-controller.patch
meta-zephyr-sdk/recipes-hosttools/bossa/files/0003-Device-Introduce-support-to-SAM4L-SoC-family.patch
meta-zephyr-sdk/recipes-hosttools/bossa/files/0004-CalwFlash-Add-NVIC-reset-command.patch
meta-zephyr-sdk/recipes-hosttools/hosttools/hosttools-tarball.bb
meta-zephyr-sdk/recipes-hosttools/openocd/openocd_git.bb
meta-zephyr-sdk/recipes-kernel/kmod/kmod_git.bbappend
meta-zephyr-sdk/recipes-support/hidapi/hidapi_git.bb
meta-zephyr-sdk/recipes-support/libftdi/libftdi_1.4.bb
meta-zephyr-sdk/recipes-support/libpcre/libpcre2_%.bbappend
meta-zephyr-sdk/recipes-support/libpcre/libpcre_%.bbappend
meta-zephyr-sdk/recipes-support/libusb/libusb-compat/0001-usb.h-Include-sys-types.h.patch
meta-zephyr-sdk/recipes-support/libusb/libusb-compat_0.1.7.bb
meta-zephyr-sdk/scripts/meta-zephyr-sdk-build.sh
meta-zephyr-sdk/scripts/meta-zephyr-sdk-clone.sh
meta-zephyr-sdk/scripts/template_dir
overlays/README.md
overlays/xtensa_espressif_esp32/binutils/bfd/xtensa-modules.c
overlays/xtensa_espressif_esp32/binutils/include/xtensa-config.h
overlays/xtensa_espressif_esp32/gcc/include/xtensa-config.h
overlays/xtensa_espressif_esp32/gdb/bfd/xtensa-modules.c
overlays/xtensa_espressif_esp32/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_espressif_esp32/gdb/gdb/xtensa-config.c
overlays/xtensa_espressif_esp32/gdb/gdb/xtensa-xtregs.c
overlays/xtensa_espressif_esp32/gdb/gdbserver/xtensa-xtregs.cc
overlays/xtensa_espressif_esp32/gdb/include/xtensa-config.h
overlays/xtensa_espressif_esp32/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_espressif_esp32s2/binutils/bfd/xtensa-modules.c
overlays/xtensa_espressif_esp32s2/gdb/bfd/xtensa-modules.c
overlays/xtensa_espressif_esp32s2/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_espressif_esp32s2/gdb/gdb/xtensa-config.c
overlays/xtensa_espressif_esp32s2/gdb/gdb/xtensa-xtregs.c
overlays/xtensa_espressif_esp32s2/gdb/gdbserver/xtensa-xtregs.cc
overlays/xtensa_espressif_esp32s2/gdb/include/xtensa-config.h
overlays/xtensa_espressif_esp32s2/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_intel_apl_adsp/binutils/bfd/xtensa-modules.c
overlays/xtensa_intel_apl_adsp/binutils/include/xtensa-config.h
overlays/xtensa_intel_apl_adsp/gcc/include/xtensa-config.h
overlays/xtensa_intel_apl_adsp/gdb/bfd/xtensa-modules.c
overlays/xtensa_intel_apl_adsp/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_intel_apl_adsp/gdb/gdb/xtensa-config.c
overlays/xtensa_intel_apl_adsp/gdb/gdb/xtensa-xtregs.c
overlays/xtensa_intel_apl_adsp/gdb/gdbserver/xtensa-xtregs.cc
overlays/xtensa_intel_apl_adsp/gdb/include/xtensa-config.h
overlays/xtensa_intel_apl_adsp/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_intel_s1000/binutils/bfd/xtensa-modules.c
overlays/xtensa_intel_s1000/binutils/include/xtensa-config.h
overlays/xtensa_intel_s1000/gdb/bfd/xtensa-modules.c
overlays/xtensa_intel_s1000/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_intel_s1000/gdb/gdb/xtensa-config.c
overlays/xtensa_intel_s1000/gdb/gdb/xtensa-xtregs.c
overlays/xtensa_intel_s1000/gdb/gdbserver/xtensa-xtregs.cc
overlays/xtensa_intel_s1000/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_nxp_imx8m_adsp/binutils/bfd/xtensa-modules.c
overlays/xtensa_nxp_imx8m_adsp/gdb/bfd/xtensa-modules.c
overlays/xtensa_nxp_imx8m_adsp/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_nxp_imx8m_adsp/gdb/gdb/xtensa-config.c
overlays/xtensa_nxp_imx8m_adsp/gdb/gdb/xtensa-xtregs.c
overlays/xtensa_nxp_imx8m_adsp/gdb/gdbserver/xtensa-xtregs.cc
overlays/xtensa_nxp_imx8m_adsp/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_nxp_imx_adsp/binutils/bfd/xtensa-modules.c
overlays/xtensa_nxp_imx_adsp/gdb/bfd/xtensa-modules.c
overlays/xtensa_nxp_imx_adsp/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_nxp_imx_adsp/gdb/gdb/xtensa-config.c
overlays/xtensa_nxp_imx_adsp/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
overlays/xtensa_sample_controller/binutils/bfd/xtensa-modules.c
overlays/xtensa_sample_controller/gdb/bfd/xtensa-modules.c
overlays/xtensa_sample_controller/gdb/gdb/regformats/reg-xtensa.dat
overlays/xtensa_sample_controller/gdb/gdb/xtensa-config.c
overlays/xtensa_sample_controller/newlib/newlib/libc/sys/xtensa/include/xtensa/config/core-isa.h
release-notes.md
scripts/template_setup_posix
scripts/template_setup_win
@alexet
Copy link
Contributor

alexet commented Feb 17, 2023

Hi, thanks for the suggestion.

The string meta-zephyr-sdk/recipes-core/expat/expat_%.bbappend is the invalid URI if it helps.

@jsoref
Copy link
Contributor Author

jsoref commented Feb 17, 2023

Thanks. I've adjusted my code to escape %.

@jsoref jsoref mentioned this issue May 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix running tests on forks, and handle invalid URIs when fingerprinting jsoref/github-codeql-action
2 participants
@jsoref @alexet