Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine UI output when "Add a new project" takes a long time #3281

Closed
koppor opened this issue Mar 22, 2024 · 4 comments
Closed

Refine UI output when "Add a new project" takes a long time #3281

koppor opened this issue Mar 22, 2024 · 4 comments
Labels
UX something related to the user's experience

Comments

@koppor
Copy link

koppor commented Mar 22, 2024

I try to add a project, then I get the spinner:

grafik

The text reads "Verify valid Git repository in selected folder before importing". I think, that should be "Verifying valid Git repository in selected folder before importing.", because the operation is ongoing (and not going to happen)

@koppor
Copy link
Author

koppor commented Mar 22, 2024

The console output is

2024-03-22T08:33:56.261249Z  INFO list_projects: gitbutler-app/src/projects/commands.rs:132: close time.busy=10.7µs time.idle=30.3µs
2024-03-22T08:34:21.503418Z  INFO add_project: gitbutler-app/src/gb_repository/repository.rs:347: created new session project_id=810b1d12-9a4d-453c-8459-9fe0458e1498 session_id=93dd3c7a-fcda-435a-8002-438848679c9a path="/mnt/c/git-repositories/JabRef"

@Byron Byron added performance Application is too slow UX something related to the user's experience feedback requested Feedback was requested to help resolve the issue labels Apr 23, 2024
@Byron
Copy link
Collaborator

Byron commented Apr 23, 2024

When I tried the Linux repository (#3512), it also took a long time, seemingly because gravatar image were eagerly loaded for all of the 30k unique authors.
Is the project you were using for testing public, so that I could try it as well? Thank you.

@koppor
Copy link
Author

koppor commented Apr 23, 2024

Yes, the project is public and available at https://github.com/jabref/jabref/.

@Byron Byron removed performance Application is too slow feedback requested Feedback was requested to help resolve the issue labels Apr 23, 2024
@Byron
Copy link
Collaborator

Byron commented Apr 23, 2024

Thanks for helping!

I think the issue here was that there were internal failures that weren't communicated very well. When trying this now, the program fails with a popup saying that repositories with submodules aren't supported.

Thus, I am closing this issue as fixed, but please feel free to keep commenting or to reopen in case I am missing something.

@Byron Byron closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX something related to the user's experience
Projects
None yet
Development

No branches or pull requests

2 participants