t9813: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Pranit Bauva <[email protected]> Acked-by: Luke Diamand <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
git · Jan 9, 2017 · c6f44e1 · c6f44e1
1 parent c7cf956
commit c6f44e1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/t/t9813-git-p4-preserve-users.sh b/t/t9813-git-p4-preserve-users.sh
@@ -118,12 +118,12 @@ test_expect_success 'not preserving user with mixed authorship' '
 		make_change_by_user usernamefile3 Derek [email protected] &&
 		P4EDITOR=cat P4USER=alice P4PASSWD=secret &&
 		export P4EDITOR P4USER P4PASSWD &&
-		git p4 commit |\
-		grep "git author [email protected] does not match" &&
+		git p4 commit >actual &&
+		grep "git author [email protected] does not match" actual &&
 
 		make_change_by_user usernamefile3 Charlie [email protected] &&
-		git p4 commit |\
-		grep "git author [email protected] does not match" &&
+		git p4 commit >actual &&
+		grep "git author [email protected] does not match" actual &&
 
 		make_change_by_user usernamefile3 alice [email protected] &&
 		git p4 commit >actual &&